From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: Linux/x86's _PAGE_SWP_SOFT_DIRTY definition Date: Wed, 21 Aug 2013 12:47:37 +0100 Message-ID: <5214A8D9.20509@citrix.com> References: <52148B8D02000078000ED3C8@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VC6tY-0001CB-LB for xen-devel@lists.xenproject.org; Wed, 21 Aug 2013 11:48:12 +0000 In-Reply-To: <52148B8D02000078000ED3C8@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel , Boris Ostrovsky List-Id: xen-devel@lists.xenproject.org On 21/08/13 08:42, Jan Beulich wrote: > All, > > was anyone of you involved in the recent (rc5->rc6) changes here? > I'm asking because this new definition conflicts with _PAGE_PAT, > which is unused only for native Linux (and I continue to not really > understand their motivation to restrict themselves to just the four > most trivial memory types). I was not aware of it and that just looks broken -- not just Xen but it looks like it wouldn't work with (transparent) huge pages either. The soft dirty tracking was introduced (in 3.11-rc1) by 0f8975ec4 (mm: soft-dirty bits for user memory changes tracking) and the problematic patch adding the conflicting PTE bit is 179ef71cb (mm: save soft-dirty bits on swapped pages). David