From: David Vrabel <david.vrabel@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: boris.ostrovsky@oracle.com, ian.campbell@citrix.com,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] xen: set P2M entry to INVALID_P2M_ENTRY for ballooned out pages
Date: Thu, 22 Aug 2013 14:00:05 +0100 [thread overview]
Message-ID: <52160B55.3000806@citrix.com> (raw)
In-Reply-To: <1377176248-10113-1-git-send-email-wei.liu2@citrix.com>
On 22/08/13 13:57, Wei Liu wrote:
> In commit cd9151e2: xen/balloon: set a mapping for ballooned out pages
> we have the ballooned out page's mapping set to a scratch page. That commit
> also set the P2M entry of ballooned out page to the scratch, which is
> not necessary. That triggers BUG_ONs in __set_phys_to_machine when the
> page is ballooned in again.
>
> We only need to ensure that the ballooned out pages have valid mapping.
> P2M entries of those pages should still be set to INVALID_P2M_ENTRY.
I know I suggested this but I would like to get Stefano's acked-by or
reviewed-by for this.
David
next prev parent reply other threads:[~2013-08-22 13:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 12:57 [PATCH] xen: set P2M entry to INVALID_P2M_ENTRY for ballooned out pages Wei Liu
2013-08-22 13:00 ` David Vrabel [this message]
2013-08-26 16:08 ` Wei Liu
2013-08-27 13:34 ` Stefano Stabellini
2013-08-27 13:42 ` David Vrabel
2013-08-27 13:44 ` Wei Liu
2013-08-27 14:05 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52160B55.3000806@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).