From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH] xen: set P2M entry to INVALID_P2M_ENTRY for
 ballooned out pages
Date: Thu, 22 Aug 2013 14:00:05 +0100
Message-ID: <52160B55.3000806@citrix.com>
References: <1377176248-10113-1-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1377176248-10113-1-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: boris.ostrovsky@oracle.com, ian.campbell@citrix.com, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 22/08/13 13:57, Wei Liu wrote:
> In commit cd9151e2: xen/balloon: set a mapping for ballooned out pages
> we have the ballooned out page's mapping set to a scratch page. That commit
> also set the P2M entry of ballooned out page to the scratch, which is
> not necessary. That triggers BUG_ONs in __set_phys_to_machine when the
> page is ballooned in again.
> 
> We only need to ensure that the ballooned out pages have valid mapping.
> P2M entries of those pages should still be set to INVALID_P2M_ENTRY.

I know I suggested this but I would like to get Stefano's acked-by or
reviewed-by for this.

David