From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: stefan.bader@canonical.com, JBeulich@suse.com, xen-devel@lists.xen.org
Subject: Re: [PATCH 1/1 V2] x86/AMD: Fix setup ssss:bb:dd:f for d0 failed
Date: Mon, 2 Sep 2013 21:36:40 -0500 [thread overview]
Message-ID: <52254B38.5040002@amd.com> (raw)
In-Reply-To: <5223A626.4030201@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 914 bytes --]
On 9/1/2013 3:40 PM, Andrew Cooper wrote:
> On 31/08/2013 01:41, suravee.suthikulpanit@amd.com wrote:
>> @@ -175,6 +176,15 @@ static int __init amd_iommu_setup_dom0_device(u8 devfn, struct pci_dev *pdev)
>>
>> if ( unlikely(!iommu) )
>> {
>> + /* Filter the bridge devices */
>> + if ( (pdev->type == DEV_TYPE_PCI_HOST_BRIDGE) )
>> + {
>> + AMD_IOMMU_DEBUG("Skipping bridge %04x:%02x:%02x.%u (type %x)\n",
>> + pdev->seg, PCI_BUS(bdf), PCI_SLOT(bdf), PCI_FUNC(bdf),
>> + pdev->type);
> I know this is being picky, but I would prefer "Skipping host bridge"
> here, to avoid any possible confusion that non-host bridges might be
> considered for being skipped.
>
> ~Andrew
>
I'm fine with that. Jan, would you mind modifying the message when you
commit the code, or you want me to send out a new patch?
Thanks.
Suravee
[-- Attachment #1.2: Type: text/html, Size: 1726 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-09-03 2:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-31 0:41 [PATCH 1/1 V2] x86/AMD: Fix setup ssss:bb:dd:f for d0 failed suravee.suthikulpanit
2013-09-01 20:40 ` Andrew Cooper
2013-09-03 2:36 ` Suravee Suthikulpanit [this message]
2013-09-04 8:53 ` Jan Beulich
2013-09-04 14:10 ` Suravee Suthikulanit
2013-09-04 8:51 ` Jan Beulich
2013-09-04 15:54 ` Suravee Suthikulanit
2013-09-05 7:03 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52254B38.5040002@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=stefan.bader@canonical.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).