From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee Suthikulanit Subject: Re: [PATCH 1/1 V2] x86/AMD: Fix setup ssss:bb:dd:f for d0 failed Date: Wed, 4 Sep 2013 09:10:21 -0500 Message-ID: <52273F4D.9010506@amd.com> References: <1377909673-4778-1-git-send-email-suravee.suthikulpanit@amd.com> <5223A626.4030201@citrix.com> <52254B38.5040002@amd.com> <5227112602000078000F0409@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7127484093205133960==" Return-path: In-Reply-To: <5227112602000078000F0409@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Andrew Cooper , stefan.bader@canonical.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============7127484093205133960== Content-Type: multipart/alternative; boundary="------------060500090709020301060603" --------------060500090709020301060603 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit On 9/4/2013 3:53 AM, Jan Beulich wrote: >>>> On 03.09.13 at 04:36, Suravee Suthikulpanit > wrote: >> On 9/1/2013 3:40 PM, Andrew Cooper wrote: >>> On 31/08/2013 01:41, suravee.suthikulpanit@amd.com wrote: >>>> @@ -175,6 +176,15 @@ static int __init amd_iommu_setup_dom0_device(u8 devfn, >> struct pci_dev *pdev) >>>> >>>> if ( unlikely(!iommu) ) >>>> { >>>> + /* Filter the bridge devices */ >>>> + if ( (pdev->type == DEV_TYPE_PCI_HOST_BRIDGE) ) >>>> + { >>>> + AMD_IOMMU_DEBUG("Skipping bridge %04x:%02x:%02x.%u (type >> %x)\n", >>>> + pdev->seg, PCI_BUS(bdf), PCI_SLOT(bdf), >> PCI_FUNC(bdf), >>>> + pdev->type); >>> I know this is being picky, but I would prefer "Skipping host bridge" >>> here, to avoid any possible confusion that non-host bridges might be >>> considered for being skipped. >>> >>> ~Andrew >>> >> I'm fine with that. Jan, would you mind modifying the message when you >> commit the code, or you want me to send out a new patch? > I'll try to remember that, but considering the reply I just sent to > the patch itself I don't think you're going to get around doing a > v3, in which case you should do the change yourself. > > Jan > I'll take care of itin V3. Suravee --------------060500090709020301060603 Content-Type: text/html; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit
On 9/4/2013 3:53 AM, Jan Beulich wrote:
On 03.09.13 at 04:36, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>

wrote:

On 9/1/2013 3:40 PM, Andrew Cooper wrote:

On 31/08/2013 01:41, suravee.suthikulpanit@amd.com wrote:

@@ -175,6 +176,15 @@ static int __init amd_iommu_setup_dom0_device(u8 devfn, 

struct pci_dev *pdev)

  
      if ( unlikely(!iommu) )
      {
+        /* Filter the bridge devices */
+        if ( (pdev->type == DEV_TYPE_PCI_HOST_BRIDGE) )
+        {
+            AMD_IOMMU_DEBUG("Skipping bridge %04x:%02x:%02x.%u (type 

%x)\n",

+                        pdev->seg, PCI_BUS(bdf), PCI_SLOT(bdf), 

PCI_FUNC(bdf),

+                        pdev->type);

I know this is being picky, but I would prefer "Skipping host bridge"
here, to avoid any possible confusion that non-host bridges might be
considered for being skipped.

~Andrew


I'm fine with that.  Jan, would you mind modifying the message when you 
commit the code, or you want me to send out a new patch?

I'll try to remember that, but considering the reply I just sent to
the patch itself I don't think you're going to get around doing a
v3, in which case you should do the change yourself.

Jan
I'll take care of it in V3.

Suravee
 --------------060500090709020301060603-- --===============7127484093205133960== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7127484093205133960==--