From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH V1 07/29] xen: Use the right string comparison function in device tree Date: Tue, 10 Sep 2013 13:51:11 +0100 Message-ID: <522F15BF.8020802@linaro.org> References: <1377701263-3319-1-git-send-email-julien.grall@linaro.org> <1377701263-3319-8-git-send-email-julien.grall@linaro.org> <1378809303.21748.85.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1378809303.21748.85.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, andre.przywara@linaro.org, patches@linaro.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 09/10/2013 11:35 AM, Ian Campbell wrote: > On Wed, 2013-08-28 at 15:47 +0100, Julien Grall wrote: >> @@ -549,7 +549,7 @@ dt_find_property(const struct dt_device_node *np, >> >> for ( pp = np->properties; pp; pp = pp->next ) >> { >> - if ( strcmp(pp->name, name) == 0 ) >> + if ( dt_prop_cmp(pp->name, name) == 0 ) > > This guy isn't added until patch #9. Good catch. I will move the patch later, thanks. -- Julien Grall