Re: [PATCH 2/8] sched/arinc653: check for guest data transfer failures

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 10/09/13 15:34, Matthew Daley wrote:
> Coverity-ID: 1055121
> Coverity-ID: 1055122
> Coverity-ID: 1055123
> Coverity-ID: 1055124
> Signed-off-by: Matthew Daley <mattjd@gmail.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

> ---
>  xen/common/sched_arinc653.c |   13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/xen/common/sched_arinc653.c b/xen/common/sched_arinc653.c
> index 63ddb82..2502192 100644
> --- a/xen/common/sched_arinc653.c
> +++ b/xen/common/sched_arinc653.c
> @@ -635,12 +635,21 @@ a653sched_adjust_global(const struct scheduler *ops,
>      switch ( sc->cmd )
>      {
>      case XEN_SYSCTL_SCHEDOP_putinfo:
> -        copy_from_guest(&local_sched, sc->u.sched_arinc653.schedule, 1);
> +        if ( copy_from_guest(&local_sched, sc->u.sched_arinc653.schedule, 1) )
> +        {
> +            rc = -EFAULT;
> +            break;
> +        }
> +
>          rc = arinc653_sched_set(ops, &local_sched);
>          break;
>      case XEN_SYSCTL_SCHEDOP_getinfo:
>          rc = arinc653_sched_get(ops, &local_sched);
> -        copy_to_guest(sc->u.sched_arinc653.schedule, &local_sched, 1);
> +        if ( rc )
> +            break;
> +
> +        if ( copy_to_guest(sc->u.sched_arinc653.schedule, &local_sched, 1) )
> +            rc = -EFAULT;
>          break;
>      }
>