From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 7/8] kdd: fix free of array-typed value
Date: Tue, 10 Sep 2013 15:46:02 +0100
Message-ID: <522F30AA.6050901@citrix.com>
References: <1378823662-20803-1-git-send-email-mattjd@gmail.com>
	<1378823662-20803-8-git-send-email-mattjd@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1378823662-20803-8-git-send-email-mattjd@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Matthew Daley <mattjd@gmail.com>
Cc: Tim Deegan <tim@xen.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 10/09/13 15:34, Matthew Daley wrote:
> g->id is an array and is allocated as part of g itself; it's not a
> separate allocation.
>
> Coverity-ID: 1054980
> Signed-off-by: Matthew Daley <mattjd@gmail.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

> ---
>  tools/debugger/kdd/kdd-xen.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/tools/debugger/kdd/kdd-xen.c b/tools/debugger/kdd/kdd-xen.c
> index 4fbea7d..f3f9529 100644
> --- a/tools/debugger/kdd/kdd-xen.c
> +++ b/tools/debugger/kdd/kdd-xen.c
> @@ -619,7 +619,6 @@ void kdd_guest_teardown(kdd_guest *g)
>  {
>      flush_maps(g);
>      xc_interface_close(g->xc_handle);
> -    free(g->id);
>      free(g->hvm_buf);
>      free(g);
>  }