From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH RFC 1/8] xen/arm: Implement ioremap.
Date: Tue, 10 Sep 2013 16:20:10 +0100
Message-ID: <522F38AA.9040105@linaro.org>
References: <1378822681.10928.8.camel@kazak.uk.xensource.com>
	<1378822705-19310-1-git-send-email-ian.campbell@citrix.com>
	<522F34CC.2030002@linaro.org>
	<1378826068.10928.23.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1378826068.10928.23.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Josh Zhao <joshsystem@gmail.com>, stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 09/10/2013 04:14 PM, Ian Campbell wrote:
> On Tue, 2013-09-10 at 16:03 +0100, Julien Grall wrote:
>> On 09/10/2013 03:18 PM, Ian Campbell wrote:
>>> Common code uses this, it expects an uncached mapping.
>>>
>>> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>>> ---
>>>  xen/arch/arm/mm.c |    5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
>>> index 69c157a..4521c8d 100644
>>> --- a/xen/arch/arm/mm.c
>>> +++ b/xen/arch/arm/mm.c
>>> @@ -694,6 +694,11 @@ void *ioremap_attr(paddr_t pa, size_t len, unsigned int attributes)
>>>      return (__vmap(&pfn, nr, 1, 1, attributes) + offs);
>>>  }
>>>  
>>> +void *ioremap(paddr_t pa, size_t len)
>>> +{
>>> +    return ioremap_attr(pa, len, PAGE_HYPERVISOR_NOCACHE);
>>> +}
>>> +
>>
>> Can you inline ioremap in the header (asm-arm/mm.h)?
> 
> It's prototyped in xen/include/xen/vmap.h so I don't think so, at least
> not without introducing subtle header inclusion order traps.
> 
> It's unlikely to be performance critical so I don't think there is a
> need to refactor the definition into arch code.

Right, so:

Reviewed-by: Julien Grall <julien.grall@linaro.org>

>>>  static int create_xen_table(lpae_t *entry)
>>>  {
>>>      void *p;
>>>
>>
> 
> 

-- 
Julien Grall