From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: andrew.cooper3@citrix.com, xen-devel@lists.xen.org, keir@xen.org,
linux@eikelenboom.it
Subject: Re: [PATCH V2] x86/AMD-Vi: Add additional check for invalid special->handle
Date: Thu, 12 Sep 2013 13:02:27 -0500 [thread overview]
Message-ID: <523201B3.7000203@amd.com> (raw)
In-Reply-To: <52319C6202000078000F2A45@nat28.tlf.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 1524 bytes --]
On 9/12/2013 3:50 AM, Jan Beulich wrote:
>>
>> Jan
>>
>> AMD IOMMU: also match IVRS overrides on device ID
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> --- a/xen/drivers/passthrough/amd/iommu_acpi.c
>> +++ b/xen/drivers/passthrough/amd/iommu_acpi.c
>> @@ -713,6 +713,24 @@ static u16 __init parse_ivhd_device_spec
>> * consistency here --- whether entry's IOAPIC ID is valid and
>> * whether there are conflicting/duplicated entries.
>> */
>> + apic = find_first_bit(ioapic_cmdline, ARRAY_SIZE(ioapic_sbdf));
>> + while ( apic < ARRAY_SIZE(ioapic_sbdf) )
>> + {
>> + if ( ioapic_sbdf[apic].bdf == bdf &&
>> + ioapic_sbdf[apic].seg == seg )
>> + break;
>> + apic = find_next_bit(ioapic_cmdline, ARRAY_SIZE(ioapic_sbdf),
>> + apic + 1);
>> + }
>> + if ( apic < ARRAY_SIZE(ioapic_sbdf) )
>> + {
>> + AMD_IOMMU_DEBUG("IVHD: Command line override present for IO-APIC %#x"
>> + "(IVRS: %#x devID %04x:%02x:%02x.%u)\n",
>> + apic, special->handle, seg, PCI_BUS(bdf),
>> + PCI_SLOT(bdf), PCI_FUNC(bdf));
>> + break;
>> + }
>> +
>> for ( apic = 0; apic < nr_ioapics; apic++ )
>> {
>> if ( IO_APIC_ID(apic) != special->handle )
>>
>>
>>
>>
Jan,
This looks good. I'll used it in V3 that I already sent out.
Suravee
[-- Attachment #1.2: Type: text/html, Size: 2337 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-09-12 18:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 17:34 [PATCH V2] x86/AMD-Vi: Add additional check for invalid special->handle suravee.suthikulpanit
2013-08-29 7:17 ` Jan Beulich
2013-08-29 20:26 ` Suravee Suthikulpanit
2013-08-30 8:06 ` Jan Beulich
2013-08-30 20:35 ` Suravee Suthikulpanit
2013-09-04 9:57 ` Jan Beulich
2013-09-04 22:48 ` Suravee Suthikulpanit
2013-09-05 7:14 ` Jan Beulich
2013-09-11 22:31 ` Suravee Suthikulpanit
2013-09-12 7:11 ` Jan Beulich
2013-09-12 8:50 ` Jan Beulich
2013-09-12 18:02 ` Suravee Suthikulpanit [this message]
2013-09-12 18:03 ` Suravee Suthikulpanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523201B3.7000203@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=keir@xen.org \
--cc=linux@eikelenboom.it \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).