From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 5/9] xen/arm: cope with modules outside of "visible" RAM Date: Fri, 13 Sep 2013 14:08:47 +0100 Message-ID: <52330E5F.2050905@linaro.org> References: <1379072409.19256.40.camel@kazak.uk.xensource.com> <1379072437-28099-5-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1379072437-28099-5-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, andre.przywara@linaro.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 09/13/2013 12:40 PM, Ian Campbell wrote: > This can happen if modules are in a bank which we can't cope with e.g. due to > being non-contiguous. > > Signed-off-by: Ian Campbell > --- > xen/arch/arm/setup.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index 8d8028c..0d9eaf7 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -387,6 +387,12 @@ static void __init setup_mm(unsigned long dtb_paddr, size_t dtb_size) > e = n = ram_end; > } > > + /* Module in RAM which we cannot see here, due to not handling > + * non-contiguous memory regions yes s/yes/yet. Except this minor typo: Reviewed-by: Julien Grall > + */ > + if ( e > ram_end ) > + e = ram_end; > + > /* Avoid the xenheap */ > if ( s < ((xenheap_mfn_start+xenheap_pages) << PAGE_SHIFT) > && (xenheap_mfn_start << PAGE_SHIFT) < e ) > -- Julien Grall