From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH RFC 4/7] xen: arm: add two new device tree helpers Date: Tue, 17 Sep 2013 14:05:48 +0100 Message-ID: <523853AC.7020209@linaro.org> References: <1379381846.11304.73.camel@hastur.hellion.org.uk> <1379382050-11821-4-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1379382050-11821-4-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 09/17/2013 02:40 AM, Ian Campbell wrote: > - dt_property_read_u64 > - dt_find_node_by_type > > Signed-off-by: Ian Campbell > --- > xen/common/device_tree.c | 29 +++++++++++++++++++++++++++++ > xen/include/xen/device_tree.h | 16 ++++++++++++++++ > 2 files changed, 45 insertions(+) > > diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c > index 3a3c99c..74a82bc 100644 > --- a/xen/common/device_tree.c > +++ b/xen/common/device_tree.c > @@ -589,6 +589,21 @@ bool_t dt_property_read_u32(const struct dt_device_node *np, > return 1; > } > > +bool_t dt_property_read_u64(const struct dt_device_node *np, > + const char *name, u64 *out_value) > +{ > + u32 len; > + const __be32 *val; > + > + val = dt_get_property(np, name, &len); > + if ( !val || len < sizeof(*out_value) ) > + return 0; > + > + *out_value = dt_read_number(val, 2); > + > + return 1; > +} > + > bool_t dt_device_is_compatible(const struct dt_device_node *device, > const char *compat) > { > @@ -637,6 +652,20 @@ struct dt_device_node *dt_find_node_by_name(struct dt_device_node *from, > return np; > } > > +struct dt_device_node *dt_find_node_by_type(struct dt_device_node *from, > + const char *type) > +{ > + struct dt_device_node *np; > + struct dt_device_node *dt; > + > + dt = from ? from->allnext : dt_host; > + for_each_device_node(dt, np) > + if ( np->type && (dt_node_cmp(np->type, type) == 0) ) > + break; > + > + return np; > +} > + > struct dt_device_node *dt_find_node_by_path(const char *path) > { > struct dt_device_node *np; > diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h > index 402cef2..3aa8452 100644 > --- a/xen/include/xen/device_tree.h > +++ b/xen/include/xen/device_tree.h > @@ -315,6 +315,16 @@ const void *dt_get_property(const struct dt_device_node *np, > */ > bool_t dt_property_read_u32(const struct dt_device_node *np, > const char *name, u32 *out_value); > +/** > + * dt_property_read_u64 - Helper to read a u64 property. > + * @np: node to get the value > + * @name: name of the property > + * @out_value: pointer to return value > + * > + * Return true if get the desired value. > + */ > +bool_t dt_property_read_u64(const struct dt_device_node *np, > + const char *name, u64 *out_value); > > /** > * Checks if the given "compat" string matches one of the strings in > @@ -347,6 +357,12 @@ struct dt_device_node *dt_find_node_by_name(struct dt_device_node *node, > const char *name); > > /** > + * dt_find_node_by_name - Find a node by its "name" property dt_find_node_by_type - Find a node by its "device_type" property Except this typo, Acked-by: Julien Grall > + */ > +struct dt_device_node *dt_find_node_by_type(struct dt_device_node *from, > + const char *type); > + > +/** > * df_find_node_by_alias - Find a node matching an alias > * @alias: The alias to match > * > -- Julien Grall