From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH RFC v2 2/2] linux/vnuma: Enables NUMA for
 domu	PV guest
Date: Tue, 17 Sep 2013 15:17:01 +0100
Message-ID: <5238645D.8020602@citrix.com>
References: <1379406841-7441-1-git-send-email-ufimtseva@gmail.com>
	<1379406841-7441-3-git-send-email-ufimtseva@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1379406841-7441-3-git-send-email-ufimtseva@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Elena Ufimtseva <ufimtseva@gmail.com>
Cc: lccycc123@gmail.com, george.dunlap@eu.citrix.com, dario.faggioli@citrix.com, xen-devel@lists.xen.org, msw@amazon.com, boris.ostrovsky@oracle.com, anddavid.vrabel@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 17/09/13 09:34, Elena Ufimtseva wrote:
> After the NUMA topology was received from Xen,
> enable NUMA during boot. Should have CONFIG_NUMA
> enabled in kernel.
> 
> Changes since v1:
> - added additional checks for PV guest and hypercall
> support before enablinf NUMA;

As I said in response to the other patch, I don't think this does the
right thing.

I think xen_vnuma_support() needs to try the vnuma hypercall and check
it is successful.

> --- a/arch/x86/xen/setup.c
> +++ b/arch/x86/xen/setup.c
> @@ -20,6 +20,7 @@
>  #include <asm/numa.h>
>  #include <asm/xen/hypervisor.h>
>  #include <asm/xen/hypercall.h>
> +#include <asm/xen/vnuma.h>
>  
>  #include <xen/xen.h>
>  #include <xen/page.h>
> @@ -583,6 +584,9 @@ void __init xen_arch_setup(void)
>  	WARN_ON(xen_set_default_idle());
>  	fiddle_vdso();
>  #ifdef CONFIG_NUMA
> -	numa_off = 1;
> +	if (!xen_initial_domain() && xen_vnuma_support())

I don't think there's a need to special case the initial domain here is
there?

> +		numa_off = 0;
> +	else
> +		numa_off = 1;
>  #endif
>  }

David