From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 3/6] xen/arm: gic: Use the correct CPU ID Date: Tue, 17 Sep 2013 16:04:22 +0100 Message-ID: <52386F76.8020508@linaro.org> References: <1378900784-16949-1-git-send-email-julien.grall@linaro.org> <1378900784-16949-4-git-send-email-julien.grall@linaro.org> <1379428575.11304.111.camel@hastur.hellion.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1379428575.11304.111.camel@hastur.hellion.org.uk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, patches@linaro.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 09/17/2013 03:36 PM, Ian Campbell wrote: > On Wed, 2013-09-11 at 12:59 +0100, Julien Grall wrote: >> +static unsigned int gic_cpu_mask(const cpumask_t *cpumask) >> +{ >> + unsigned int cpu; >> + unsigned int mask = 0; >> + >> + for_each_cpu(cpu, cpumask) >> + { >> + ASSERT(cpu < NR_GIC_CPU_IF); >> + mask = per_cpu(gic_cpu_id, cpu); > > Did you mean for this to be |= or something else? Oh, right. I will update the patch and send it again. -- Julien Grall