From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH 2/3] x86/AMD-Vi: Clean up code for handling IVRS IOAPIC override
Date: Tue, 17 Sep 2013 10:06:06 -0500 [thread overview]
Message-ID: <52386FDE.5000605@amd.com> (raw)
In-Reply-To: <5236CF6902000078000F3812@nat28.tlf.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 725 bytes --]
On 09/16/2013 02:29 AM, Jan Beulich wrote:
>>>> On 14.09.13 at 01:30, <suravee.suthikulpanit@amd.com> wrote:
>> @@ -745,10 +745,7 @@ static u16 __init parse_ivhd_device_special(
>> return 0;
>> }
>>
>> - if ( test_bit(special->handle, ioapic_cmdline) )
>> - AMD_IOMMU_DEBUG("IVHD: Command line override present for IO-APIC %#x\n",
>> - special->handle);
>> - else if ( ioapic_sbdf[special->handle].pin_2_idx )
>> + if ( ioapic_sbdf[special->handle].pin_2_idx )
> Once again: Why is this unnecessary?
>
> Jan
>
>
Ok... you are right. This part should handles the case when the IVRS
entry has bad BDF.
Suravee
[-- Attachment #1.2: Type: text/html, Size: 1416 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-09-17 15:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 23:30 [PATCH 0/3 V4] x86/AMD-Vi: Miscs patch to fix and clean up ivrs override suravee.suthikulpanit
2013-09-13 23:30 ` [PATCH 1/3] x86/AMD-Vi: Overrides special->handle in IVRS IOAPIC suravee.suthikulpanit
2013-09-13 23:30 ` [PATCH 2/3] x86/AMD-Vi: Clean up code for handling IVRS IOAPIC override suravee.suthikulpanit
2013-09-16 7:29 ` Jan Beulich
2013-09-17 15:06 ` Suravee Suthikulpanit [this message]
2013-09-13 23:30 ` [PATCH 3/3] x86/AMD-Vi: Fix IVRS HPET special->handle override suravee.suthikulpanit
2013-09-16 8:03 ` Jan Beulich
2013-09-17 15:07 ` Suravee Suthikulpanit
[not found] ` <523862B8.8000207@amd.com>
2013-09-17 15:30 ` Jan Beulich
2013-09-20 21:38 ` Suravee Suthikulanit
2013-09-23 6:52 ` Jan Beulich
2013-09-23 16:48 ` Suravee Suthikulpanit
2013-09-23 17:03 ` Andrew Cooper
2013-09-23 23:55 ` Suravee Suthikulanit
2013-09-24 9:35 ` Jan Beulich
2013-09-24 6:47 ` Jan Beulich
2013-09-24 23:26 ` Suravee Suthikulanit
2013-09-25 6:12 ` Jan Beulich
2013-09-25 15:01 ` Suravee Suthikulpanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52386FDE.5000605@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).