From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Jacob Shin <jacob.shin@amd.com>, Tim Deegan <tim@xen.org>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 4/9] passthrough/amd: Shuffle declaration.
Date: Tue, 17 Sep 2013 10:19:46 -0500 [thread overview]
Message-ID: <52387312.4000504@amd.com> (raw)
In-Reply-To: <5231E5D002000078000F2C6F@nat28.tlf.novell.com>
On 09/12/2013 09:03 AM, Jan Beulich wrote:
>>>> On 12.09.13 at 15:44, Tim Deegan <tim@xen.org> wrote:
>> At 14:38 +0100 on 12 Sep (1378996715), Jan Beulich wrote:
>>>>>> On 12.09.13 at 14:15, Tim Deegan <tim@xen.org> wrote:
>>>> Coverity's parser chokes on seeing __section() before the type.
>>>>
>>>> Coverity CID 1087190
>>>>
>>>> Signed-off-by: Tim Deegan <tim@xen.org>
>>>> Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
>>>> Cc: Jacob Shin <jacob.shin@amd.com>
>>>> ---
>>>> xen/drivers/passthrough/amd/iommu_acpi.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/xen/drivers/passthrough/amd/iommu_acpi.c
>>>> b/xen/drivers/passthrough/amd/iommu_acpi.c
>>>> index 89b359c..2bfe61e 100644
>>>> --- a/xen/drivers/passthrough/amd/iommu_acpi.c
>>>> +++ b/xen/drivers/passthrough/amd/iommu_acpi.c
>>>> @@ -633,7 +633,7 @@ static u16 __init parse_ivhd_device_extended_range(
>>>> return dev_length;
>>>> }
>>>>
>>>> -static __initdata DECLARE_BITMAP(ioapic_cmdline, ARRAY_SIZE(ioapic_sbdf));
>>>> +static DECLARE_BITMAP(__initdata ioapic_cmdline, ARRAY_SIZE(ioapic_sbdf));
>>> But putting it inside the DECLARE_BITMAP() doesn't seem that nice
>>> either. I think the second best option - if we need to play such
>>> games for Coverity in the first place -
>> Yes, I think the question of how much we're willing to accommodate
>> Coverity in our source code needs to be discussed. On that subject I
>> have an RFC patch that introduces some annotation...
>>
>>> would be to put this at the end.
>> Yes, that sounds better. Thus?
> Ack.
>
>> --- a/xen/drivers/passthrough/amd/iommu_acpi.c
>> +++ b/xen/drivers/passthrough/amd/iommu_acpi.c
>> @@ -633,7 +633,7 @@ static u16 __init parse_ivhd_device_extended_range(
>> return dev_length;
>> }
>>
>> -static __initdata DECLARE_BITMAP(ioapic_cmdline, ARRAY_SIZE(ioapic_sbdf));
>> +static DECLARE_BITMAP(ioapic_cmdline, ARRAY_SIZE(ioapic_sbdf)) __initdata;
>>
>> static void __init parse_ivrs_ioapic(char *str)
>> {
>>
>> Tim.
Acked-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
next prev parent reply other threads:[~2013-09-17 15:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 12:15 More Coverity-reported issues Tim Deegan
2013-09-12 12:15 ` [PATCH 1/9] x86/mm: Don't dereference p2m pointer before NULL check Tim Deegan
2013-09-12 12:15 ` [PATCH 2/9] passthrough/amd: Drop unnecessary lock lookup Tim Deegan
2013-09-12 13:35 ` Jan Beulich
2013-09-12 12:15 ` [PATCH 3/9] passthrough/amd: Missing 'break' Tim Deegan
2013-09-17 15:04 ` Suravee Suthikulpanit
2013-09-12 12:15 ` [PATCH 4/9] passthrough/amd: Shuffle declaration Tim Deegan
2013-09-12 13:38 ` Jan Beulich
2013-09-12 13:44 ` Tim Deegan
2013-09-12 14:03 ` Jan Beulich
2013-09-17 15:19 ` Suravee Suthikulpanit [this message]
2013-09-12 12:15 ` [PATCH 5/9] cpufreq: avoid integer overflows Tim Deegan
2013-09-12 13:49 ` Jan Beulich
2013-09-13 7:18 ` Liu, Jinsong
2013-09-12 12:15 ` [PATCH 6/9] cpufreq: missing check of copy_from_guest() Tim Deegan
2013-09-12 13:54 ` Jan Beulich
2013-09-13 7:18 ` Liu, Jinsong
2013-09-12 12:15 ` [PATCH 7/9] ehci-dbgp: avoid division by zero Tim Deegan
2013-09-12 13:55 ` Jan Beulich
2013-09-12 12:15 ` [PATCH 8/9] ehci-dbgp: drop dead code Tim Deegan
2013-09-12 14:01 ` Jan Beulich
2013-09-12 12:15 ` [PATCH 9/9] acpi/pmstat: fix check for empty name strings Tim Deegan
2013-09-12 14:02 ` Jan Beulich
2013-09-12 13:11 ` More Coverity-reported issues Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52387312.4000504@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=JBeulich@suse.com \
--cc=jacob.shin@amd.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).