xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: julien.grall@citrix.com, stefano.stabellini@eu.citrix.com,
	tim@xen.org, xen-devel@lists.xen.org
Subject: Re: [PATCH RFC 5/7] xen: arm: rewrite start of day page table and cpu bring up
Date: Wed, 18 Sep 2013 18:06:21 +0100	[thread overview]
Message-ID: <5239DD8D.8090001@linaro.org> (raw)
In-Reply-To: <1379382050-11821-5-git-send-email-ian.campbell@citrix.com>

On 09/17/2013 02:40 AM, Ian Campbell wrote:

> diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
> index b8334e2..abaacfd 100644
> --- a/xen/arch/arm/arm32/head.S
> +++ b/xen/arch/arm/arm32/head.S
> @@ -37,6 +37,25 @@

[..]

> +
> +common_start:
> +        mov   r7, #0                 /* r13 := CPU ID */
> +        mrc   CP32(r1, MPIDR)
> +        tst   r1, #(1<<31)           /* Multiprocessor extension supported? */
> +        beq   1f
> +        tst   r1, #(1<<30)           /* Uniprocessor system? */
> +        bne   1f
> +        bic   r7, r1, #(0xff << 24)  /* Mask out flags to get CPU ID */

Can you use #(~MPIDR_HWID_MASK) instead of #(0xff << 24)?
I think, it's the same in arm64/head.S.

-- 
Julien Grall

  parent reply	other threads:[~2013-09-18 17:06 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-17  1:37 [PATCH RFC 0/N] xen: arm: rework early bring up Ian Campbell
2013-09-17  1:40 ` [PATCH RFC 1/7] xen: arm: Load xen under 4GB on 32-bit Ian Campbell
2013-09-18 15:44   ` Julien Grall
2013-09-19  9:21   ` Tim Deegan
2013-09-17  1:40 ` [PATCH RFC 2/7] xen: arm: Log the raw MIDR on boot Ian Campbell
2013-09-17 12:05   ` Julien Grall
2013-09-19  9:21   ` Tim Deegan
2013-09-17  1:40 ` [PATCH RFC 3/7] xen: arm: make sure we stay within the memory bank during mm setup Ian Campbell
2013-09-17 12:19   ` Julien Grall
2013-09-19  9:27     ` Tim Deegan
2013-09-17  1:40 ` [PATCH RFC 4/7] xen: arm: add two new device tree helpers Ian Campbell
2013-09-17 13:05   ` Julien Grall
2013-09-18 17:11   ` Julien Grall
2013-09-18 17:14     ` Ian Campbell
2013-09-17  1:40 ` [PATCH RFC 5/7] xen: arm: rewrite start of day page table and cpu bring up Ian Campbell
2013-09-17 16:18   ` Julien Grall
2013-09-17 16:36     ` Ian Campbell
2013-09-17 16:55       ` Julien Grall
2013-09-17 18:30         ` Andre Przywara
2013-09-17 19:19           ` Ian Campbell
2013-09-18 13:57   ` Julien Grall
2013-09-18 15:12     ` Ian Campbell
2013-09-18 17:06   ` Julien Grall [this message]
2013-09-18 17:14     ` Ian Campbell
2013-09-19 11:36   ` Tim Deegan
2013-09-20 17:09     ` Ian Campbell
2013-09-20 17:16     ` Ian Campbell
2013-09-19 13:36   ` Tim Deegan
2013-09-17  1:40 ` [PATCH RFC 6/7] xen: arm: configure TCR_EL2 for 40 bit physical address space Ian Campbell
2013-09-18 15:50   ` Julien Grall
2013-09-19 13:42   ` Tim Deegan
2013-09-17  1:40 ` [PATCH RFC 7/7] xen: arm: split cpu0's domheap mapping PTs out from xen_second Ian Campbell
2013-09-19 13:47   ` Tim Deegan
2013-09-17 11:34 ` [PATCH RFC 0/N] xen: arm: rework early bring up Julien Grall
2013-09-17 12:43   ` Ian Campbell
2013-09-18 13:40     ` Julien Grall
2013-09-18 17:33 ` Julien Grall
2013-09-18 19:22   ` Ian Campbell
2013-09-18 19:24     ` Ian Campbell
2013-09-18 20:00       ` Julien Grall
2013-09-18 20:22         ` Ian Campbell
2013-09-18 21:14           ` Julien Grall
2013-09-18 21:28             ` Ian Campbell
2013-09-19 14:49               ` Julien Grall
2013-09-19 15:51                 ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5239DD8D.8090001@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=julien.grall@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).