From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 1/4] xen: arm64: Add Basic Platform support for APM X-Gene Storm. Date: Fri, 20 Sep 2013 14:41:50 +0100 Message-ID: <523C509E.9020009@linaro.org> References: <1379670763-14895-1-git-send-email-pranavkumar@linaro.org> <1379670763-14895-2-git-send-email-pranavkumar@linaro.org> <523C3B08.1000909@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Pranavkumar Sawargaonkar Cc: ian.campbell@citrix.com, Anup Patel , patches@linaro.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, Pranavkumar Sawargaonkar List-Id: xen-devel@lists.xenproject.org On 09/20/2013 02:28 PM, Pranavkumar Sawargaonkar wrote: > HI Julien, > > On Fri, Sep 20, 2013 at 5:39 PM, Julien Grall wrote: >> On 09/20/2013 10:52 AM, Pranavkumar Sawargaonkar wrote: >>> This patch adds following things: >>> Early printk support for APM X-Gene platform. >> >> Does the UART is compatible with 8250? > > Yes it is compatible but it is ns16550. [..] > I think better name would be debug-ns16550.inc ?? There are some UARTs that are 8250-compatible but not ns16550-compatible. It would be better to stay as generic as possible to support numerous UART. >> Also, can you divide this patch in 2 part: >> - Early printk support; >> - Initial platform support. >> >> Shouldn't it be only enabled on ARM64? > > But then arm32 boards should be only compiled for arm32 ? Right :). We begin to have multiple platforms that are only supported in one architecture (arm32 or arm64). So it's good time to introduce a way to compile only supported platform. -- Julien Grall