From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH RFC v12 13/21] pvh: Support read_segment_register for PVH Date: Fri, 20 Sep 2013 15:18:21 +0100 Message-ID: <523C592D.7070901@eu.citrix.com> References: <1379089521-25720-1-git-send-email-george.dunlap@eu.citrix.com> <1379089521-25720-14-git-send-email-george.dunlap@eu.citrix.com> <5239DB4202000078000F4716@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VN1XQ-0006S5-Mz for xen-devel@lists.xenproject.org; Fri, 20 Sep 2013 14:18:28 +0000 In-Reply-To: <5239DB4202000078000F4716@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel , Keir Fraser , Tim Deegan List-Id: xen-devel@lists.xenproject.org On 18/09/13 15:56, Jan Beulich wrote: >>>> On 13.09.13 at 18:25, George Dunlap wrote: >> This will be necessary to do PV-style emulated operations for PVH guests. >> >> Signed-off-by: George Dunlap >> Signed-off-by: Mukesh Rathor > Reviewed-by: Jan Beulich Jan, There are a couple of patches where I'm taking your advice, but also doing a handful of other minor clean-ups; for instance, in this patch I'm renaming the public function "hvm_read_selector" rather than "pvh_get_selector" to make the naming consistent. Would you like me to retain the Reviewed-by, to remind you that you've basically already approved the patch, and let you withdraw it if you don't like the minor changes (which will be listed in the description)? Or shall I leave it off and let you review it again? -George