From: Suravee Suthikulanit <suravee.suthikulpanit@amd.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 3/3] x86/AMD-Vi: Fix IVRS HPET special->handle override
Date: Fri, 20 Sep 2013 16:38:36 -0500 [thread overview]
Message-ID: <523CC05C.7030903@amd.com> (raw)
In-Reply-To: <523891C902000078000F4070@nat28.tlf.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 1454 bytes --]
On 9/17/2013 10:30 AM, Jan Beulich wrote:
>>> This (unconditional) assignment is what the earlier logic attempted
>>> >>to avoid: We must not blindly set this (and in particular not blindly
>>> >>overwrite a previously set valid value), and in order to do so we
>>> >>need to know whether to trust devid or handle. I'm therefore going
>>> >>to apply only the first hunk - being a clear and obvious bug fix - for
>>> >>the time being.
>>> >>
>> >But since we only allow one HPET in the system, and if users want to
>> >override the one that is in the IVRS (the buggy one)
>> >we should allow this, right? Otherwise, if the special->handle doesn't
>> >match, it would end up causing this logic to complain
>> >about multiple HPETs.
> We must not allow multiple HPET entries in the ACPI tables to
> confuse us and store a bad IOMMU pointer.
I understand this part and agree. Currently, the patch does not allow
multiple HPET in the system.
If user specifies the ivrs_hpet, that will be the one that get used, and
ignore the one that
is in the IVRS. Although, it will be pointing to the IOMMU which lists
HPET in the IVRS.
However, if IVRS is listing multiple HPETs in different IOMMUs, then it
will just default to the first IOMMU.
I don't see this case happening though since HPET is in the Southbridge
which only has one in the system.
Am I missing any thing?
Suravee
> And yes, we also must not wrongly complain about multiple HEPTs.
>
> Jan
[-- Attachment #1.2: Type: text/html, Size: 2749 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-09-20 21:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 23:30 [PATCH 0/3 V4] x86/AMD-Vi: Miscs patch to fix and clean up ivrs override suravee.suthikulpanit
2013-09-13 23:30 ` [PATCH 1/3] x86/AMD-Vi: Overrides special->handle in IVRS IOAPIC suravee.suthikulpanit
2013-09-13 23:30 ` [PATCH 2/3] x86/AMD-Vi: Clean up code for handling IVRS IOAPIC override suravee.suthikulpanit
2013-09-16 7:29 ` Jan Beulich
2013-09-17 15:06 ` Suravee Suthikulpanit
2013-09-13 23:30 ` [PATCH 3/3] x86/AMD-Vi: Fix IVRS HPET special->handle override suravee.suthikulpanit
2013-09-16 8:03 ` Jan Beulich
2013-09-17 15:07 ` Suravee Suthikulpanit
[not found] ` <523862B8.8000207@amd.com>
2013-09-17 15:30 ` Jan Beulich
2013-09-20 21:38 ` Suravee Suthikulanit [this message]
2013-09-23 6:52 ` Jan Beulich
2013-09-23 16:48 ` Suravee Suthikulpanit
2013-09-23 17:03 ` Andrew Cooper
2013-09-23 23:55 ` Suravee Suthikulanit
2013-09-24 9:35 ` Jan Beulich
2013-09-24 6:47 ` Jan Beulich
2013-09-24 23:26 ` Suravee Suthikulanit
2013-09-25 6:12 ` Jan Beulich
2013-09-25 15:01 ` Suravee Suthikulpanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523CC05C.7030903@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).