From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH 01/13] xen/events: refactor retrigger_dynirq() and resend_irq_on_evtchn() Date: Tue, 24 Sep 2013 17:04:24 +0100 Message-ID: <5241B808.1010900@cantab.net> References: <1379091601-30358-1-git-send-email-david.vrabel@citrix.com> <1379091601-30358-2-git-send-email-david.vrabel@citrix.com> <20130924143724.GB4712@phenom.dumpdata.com> Reply-To: David Vrabel Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130924143724.GB4712@phenom.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Boris Ostrovsky , David Vrabel , Jan Beulich , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 24/09/2013 15:37, Konrad Rzeszutek Wilk wrote: > On Fri, Sep 13, 2013 at 05:59:49PM +0100, David Vrabel wrote: >> From: David Vrabel >> >> These two function did the same thing with different parameters, put >> the common bits in retrigger_evtchn(). > > Plus the 'resend_irq_on_evtchn' does not look to be used by anybody. It's used by ia64 but I guess that counts at not used by anybody... The caller in ia64 ignores the return value which is why we get away with this refactoring. David