From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <dvrabel@cantab.net>
Subject: Re: [PATCH 12/13] xen/events: Add the hypervisor
 interface for the FIFO-based event channels
Date: Tue, 24 Sep 2013 17:11:54 +0100
Message-ID: <5241B9CA.9030005@cantab.net>
References: <1379091601-30358-1-git-send-email-david.vrabel@citrix.com>
	<1379091601-30358-13-git-send-email-david.vrabel@citrix.com>
	<20130924150856.GL4712@phenom.dumpdata.com>
Reply-To: David Vrabel <david.vrabel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20130924150856.GL4712@phenom.dumpdata.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>, David Vrabel <david.vrabel@citrix.com>, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 24/09/2013 16:08, Konrad Rzeszutek Wilk wrote:
>> +/*
>> + * FIFO ABI
>> + */
>> +
>> +/* Events may have priorities from 0 (highest) to 15 (lowest). */
>> +#define EVTCHN_FIFO_PRIORITY_MIN     15
>> +#define EVTCHN_FIFO_PRIORITY_DEFAULT 7
>> +
>> +#define EVTCHN_FIFO_MAX_QUEUES (EVTCHN_FIFO_PRIORITY_MIN + 1)
>> +
>> +typedef uint32_t event_word_t;
> 
> Typedefs are frowed upon in the Linux kernel. Can you just use uint32_t
> please?

Checkpatch frowned at this too but I just frowned back.  I think this
specific typedef improves maintainability so I'm not inclined to remove
it to satisfy an arbitrary rule.

David