From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: Re: [PATCH RFC 08/12] libxl: don't launch Qemu on Dom0 for Qdisk devices on driver domains Date: Wed, 25 Sep 2013 17:13:55 +0200 Message-ID: <5242FDB3.70709@citrix.com> References: <1379932259-46104-1-git-send-email-roger.pau@citrix.com> <1379932259-46104-9-git-send-email-roger.pau@citrix.com> <1380121575.4910.10.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VOqmu-0000Ih-Lk for xen-devel@lists.xenproject.org; Wed, 25 Sep 2013 15:14:00 +0000 In-Reply-To: <1380121575.4910.10.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Ian Jackson List-Id: xen-devel@lists.xenproject.org On 25/09/13 17:06, Ian Campbell wrote: > On Mon, 2013-09-23 at 12:30 +0200, Roger Pau Monne wrote: >> In libxl__need_xenpv_qemu check that the backend domain of the Qdisk >> device is Dom0 before launching a Qemu instance in the toolstack >> domain. > > Should the check not be disks[i].backend == domid from the function you > added in patch #1? Yes it could be, and it's probably easier to understand. I did it this way because the only user of this function is the toolstack domain, driver domains don't make use of it.