From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 2/2] microcode: Check whether the microcode is correct. Date: Wed, 25 Sep 2013 16:39:58 +0100 Message-ID: <524303CE.2060404@citrix.com> References: <1380122984-6555-1-git-send-email-konrad.wilk@oracle.com> <1380122984-6555-3-git-send-email-konrad.wilk@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VOrC7-0004Gg-TT for xen-devel@lists.xenproject.org; Wed, 25 Sep 2013 15:40:06 +0000 In-Reply-To: <1380122984-6555-3-git-send-email-konrad.wilk@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xenproject.org, david.vrabel@citrix.com, jbeulich@suse.com List-Id: xen-devel@lists.xenproject.org On 25/09/13 16:29, Konrad Rzeszutek Wilk wrote: > We do the microcode code update in two steps - the presmp: > 'microcode_presmp_init' and when CPUs are brought up: > 'microcode_init'. The earlier performs the microcode update > on the BSP - but unfortunately it does not check whether the > update failed. Which means that we might try later to update > a incorrect payload on the rest of CPUs. > > This patch handles this odd situation. > > Signed-off-by: Konrad Rzeszutek Wilk > [v2: Redid it as we are not doing scan and at the same time] > --- > xen/arch/x86/microcode.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/x86/microcode.c b/xen/arch/x86/microcode.c > index e6344cf..ce2fe50 100644 > --- a/xen/arch/x86/microcode.c > +++ b/xen/arch/x86/microcode.c > @@ -418,6 +418,7 @@ static int __init microcode_presmp_init(void) > { > void *data; > size_t len; > + int rc = 0; > > if ( ucode_blob.size ) > { > @@ -430,10 +431,23 @@ static int __init microcode_presmp_init(void) > data = ucode_mod_map(&ucode_mod); > } > if ( data ) > - microcode_update_cpu(data, len); > + rc = microcode_update_cpu(data, len); > + else > + rc = -ENOMEM; > > if ( !ucode_blob.size ) > ucode_mod_map(NULL); > + > + if ( rc ) > + { > + if ( ucode_blob.size ) > + { > + xfree(ucode_blob.data); > + ucode_blob.size = 0; > + ucode_blob.data = NULL; > + } else coding style. Once fixed, Reviewed-by: Andrew Cooper > + ucode_mod.mod_end = 0; > + } > } > > register_cpu_notifier(µcode_percpu_nfb);