From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, patches@linaro.org,
xen-devel@lists.xen.org
Subject: Re: [PATCH v3 3/6] xen/arm: gic: Use the correct CPU ID
Date: Wed, 25 Sep 2013 16:42:00 +0100 [thread overview]
Message-ID: <52430448.2000904@linaro.org> (raw)
In-Reply-To: <1380123356.4910.31.camel@kazak.uk.xensource.com>
On 09/25/2013 04:35 PM, Ian Campbell wrote:
> On Fri, 2013-09-20 at 16:03 +0100, Julien Grall wrote:
>> +static unsigned int gic_cpu_mask(const cpumask_t *cpumask)
>> +{
>> + unsigned int cpu;
>> + unsigned int mask = 0;
>> + cpumask_t possible_mask;
>> +
>> + cpumask_and(&possible_mask, cpumask, &cpu_possible_map);
>> + for_each_cpu(cpu, &possible_mask)
>> + {
>> + ASSERT(cpu < NR_GIC_CPU_IF);
>> + ASSERT(__per_cpu_offset[cpu] != -(long)__per_cpu_start);
>
> This should be INVALID_PERCPU_AREA, but that is private to percpu.c. I
> think we can live without this check. After all the CPU is in possible
> map.
Being in cpu possible map doesn't mean that the per cpu region is
initialized for the given cpu.
I have noticed the INVALID_PERCPU_AREA is the same both Intel and ARM
platform. Can we move this define in percpu.h?
--
Julien Grall
next prev parent reply other threads:[~2013-09-25 15:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 13:15 [PATCH v3 0/6] Dissociate logical and gic/hardware CPU ID Julien Grall
2013-09-18 13:15 ` [PATCH v3 1/6] xen/arm: use cpumask_t to describe cpu mask in gic_route_dt_irq Julien Grall
2013-09-25 15:36 ` Ian Campbell
2013-09-18 13:15 ` [PATCH v3 2/6] xen/arm: Initialize correctly IRQ routing Julien Grall
2013-09-25 15:37 ` Ian Campbell
2013-09-18 13:15 ` [PATCH v3 3/6] xen/arm: gic: Use the correct CPU ID Julien Grall
2013-09-20 12:44 ` Julien Grall
2013-09-20 13:36 ` Ian Campbell
2013-09-20 13:49 ` Julien Grall
2013-09-20 15:03 ` Julien Grall
2013-09-20 15:44 ` Ian Campbell
2013-09-20 15:58 ` Julien Grall
2013-09-20 16:06 ` Ian Campbell
2013-09-20 18:48 ` Julien Grall
2013-09-25 15:35 ` Ian Campbell
2013-09-25 15:42 ` Julien Grall [this message]
2013-09-25 15:48 ` Ian Campbell
2013-09-25 15:53 ` Ian Campbell
2013-09-25 16:34 ` Tim Deegan
2013-09-18 13:15 ` [PATCH v3 4/6] xen/arm: Fix assert in send_SGI_one Julien Grall
2013-09-25 15:37 ` Ian Campbell
2013-09-18 13:15 ` [PATCH v3 5/6] xen/arm: Dissociate logical and hardware CPU ID Julien Grall
2013-09-25 15:38 ` Ian Campbell
2013-09-18 13:15 ` [PATCH v3 6/6] xen/arm: Use the hardware ID to boot correctly secondary cpus Julien Grall
2013-09-25 15:41 ` Ian Campbell
2013-09-26 10:18 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52430448.2000904@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=patches@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).