From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 3/6] xen/arm: gic: Use the correct CPU ID Date: Wed, 25 Sep 2013 16:42:00 +0100 Message-ID: <52430448.2000904@linaro.org> References: <1379510122-9467-1-git-send-email-julien.grall@linaro.org> <1379510122-9467-4-git-send-email-julien.grall@linaro.org> <523C63C9.1040708@linaro.org> <1380123356.4910.31.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1380123356.4910.31.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, patches@linaro.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 09/25/2013 04:35 PM, Ian Campbell wrote: > On Fri, 2013-09-20 at 16:03 +0100, Julien Grall wrote: >> +static unsigned int gic_cpu_mask(const cpumask_t *cpumask) >> +{ >> + unsigned int cpu; >> + unsigned int mask = 0; >> + cpumask_t possible_mask; >> + >> + cpumask_and(&possible_mask, cpumask, &cpu_possible_map); >> + for_each_cpu(cpu, &possible_mask) >> + { >> + ASSERT(cpu < NR_GIC_CPU_IF); >> + ASSERT(__per_cpu_offset[cpu] != -(long)__per_cpu_start); > > This should be INVALID_PERCPU_AREA, but that is private to percpu.c. I > think we can live without this check. After all the CPU is in possible > map. Being in cpu possible map doesn't mean that the per cpu region is initialized for the given cpu. I have noticed the INVALID_PERCPU_AREA is the same both Intel and ARM platform. Can we move this define in percpu.h? -- Julien Grall