From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH 12/13] xen/events: Add the hypervisor interface for the FIFO-based event channels Date: Thu, 26 Sep 2013 12:06:56 +0100 Message-ID: <52441550.4040902@citrix.com> References: <1379091601-30358-1-git-send-email-david.vrabel@citrix.com> <1379091601-30358-13-git-send-email-david.vrabel@citrix.com> <20130924150622.GK4712@phenom.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130924150622.GK4712@phenom.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Boris Ostrovsky , Jan Beulich , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 24/09/13 16:06, Konrad Rzeszutek Wilk wrote: > On Fri, Sep 13, 2013 at 06:00:00PM +0100, David Vrabel wrote: >> From: David Vrabel >> >> Add the hypercall sub-ops and the structures for the shared data used >> in the FIFO-based event channel ABI. > > And you should include an URL to the design document. Or include the > text version of it (if possible) in this description. The design doc is 16 pages and has diagrams, not something that could be included in a commit message. I'll add a link. >> +struct evtchn_fifo_control_block { >> + uint32_t ready; >> + uint32_t _rsvd1; > > > The design document looks to have 'READY' be 2 bytes? Octet 0 and 1? > (figure 2). The docs need to be updated -- we only require the guest to be able to do atomic ops on 32-bit values. David