From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v2 5/9] xen: arm: implement arch/platform
 SMP and CPU initialisation framework
Date: Thu, 26 Sep 2013 15:06:11 +0100
Message-ID: <52443F53.4030602@linaro.org>
References: <1380192538.29483.63.camel@kazak.uk.xensource.com>
	<1380192556-30700-5-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1380192556-30700-5-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 09/26/2013 11:49 AM, Ian Campbell wrote:
> +
> +static int vexpress_smp_init(void)
> +{
> +    void __iomem *sysflags;
> +
> +    sysflags = ioremap_nocache(V2M_SYS_MMIO_BASE, PAGE_SIZE);
> +    if ( !sysflags )
> +    {
> +        dprintk(XENLOG_ERR, "Unable to map vexpress MMIO\n");
> +        return -EFAULT;
> +    }
> +
> +    printk("Set SYS_FLAGS to %"PRIpaddr" (%p)\n",
> +           __pa(init_secondary), init_secondary);
> +    iowritel(sysflags + V2M_SYS_FLAGSCLR, ~0);
> +    iowritel(sysflags + V2M_SYS_FLAGSSET,
> +             __pa(init_secondary));

You need to replace iowritel by writel.
Otherwise:
Acked-by: Julien Grall <julien.grall@linaro.org>

-- 
Julien Grall