From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 1/4] xen/arm: Add macro MB Date: Thu, 26 Sep 2013 16:26:11 +0100 Message-ID: <52445213.6010905@linaro.org> References: <1380200178-30776-1-git-send-email-julien.grall@linaro.org> <1380200178-30776-2-git-send-email-julien.grall@linaro.org> <1380205963.29483.103.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1380205963.29483.103.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, andre.przywara@linaro.org, patches@linaro.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 09/26/2013 03:32 PM, Ian Campbell wrote: > On Thu, 2013-09-26 at 13:56 +0100, Julien Grall wrote: >> Signed-off-by: Julien Grall >> --- >> xen/include/asm-arm/config.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h >> index 604088e..2cea1ba 100644 >> --- a/xen/include/asm-arm/config.h >> +++ b/xen/include/asm-arm/config.h >> @@ -119,6 +119,7 @@ >> #define BOOT_MISC_VIRT_START _AT(vaddr_t,0x00600000) >> >> #define HYPERVISOR_VIRT_START XEN_VIRT_START >> +#define MB(_mb) (_AC(_mb, UL) << 20) > > Can you move the GB here too for consistency. > > In fact it would be worth considering moving this to > xen/include/xen/config.h and consolidating the x86 version too. I will do. I'm wondering, do we need to use ULL instead of UL in GB and MB? -- Julien Grall