xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: George.Dunlap@eu.citrix.com, xen-devel@lists.xensource.com,
	Ian.Jackson@eu.citrix.com
Subject: Re: [PATCH 1/2] xl: neuter vcpu-set --ignore-host.
Date: Thu, 26 Sep 2013 17:01:26 +0100	[thread overview]
Message-ID: <52445A56.6060505@citrix.com> (raw)
In-Reply-To: <1380210460.29483.134.camel@kazak.uk.xensource.com>

On 26/09/13 16:47, Ian Campbell wrote:
> On Thu, 2013-09-26 at 11:28 -0400, Konrad Rzeszutek Wilk wrote:
>>>>  - The user can already boot a massively overcommitted guest by
>>>>    having a large 'vcpus=' value in the guest config and we allow
>>>>    that.
>>> IMHO this is an xl bug, I'd be happy to see a patch to fix this and
>>> require and override here too.
>> I actually think that doing vCPU overcommit is an OK process. If you go
>> down the path of 'don't do this b/c it can cause performance degredation'
>> you might end up with tons of things that we should be turning off:
>>  - don't use file but use phy for block.
>>  - if you have 40GB SR-IOV, use that instead of vif.
>>  - booting PV? You should be booting it in HVM mode on latest machines.
>>  - etc.
> Those are all legitimate choices for a user to make. 
>
> Overcommitting VCPUs is not.

Depends how the overcommitting happens.  What about:

* User creating N VMs which are individually undercomitted but has the
same effect as creating 1 VM which is stupidly overcommitted.

* Power management decides to shut down some of the PCPUs because it can
service all the current VCPUs from some somewhat idle domains on fewer PCPUs


While I agree that creating a single VM which is overcommitted in terms
of VCPUs is either a user error or power-user, that alone is not a
justification for it being impossible/very hard to do.

My two cents.

~Andrew

  reply	other threads:[~2013-09-26 16:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-25 20:40 [RFC] Make xl vcpu-set work in overcommit and with PV guests. (v2) Konrad Rzeszutek Wilk
2013-09-25 20:40 ` [PATCH 1/2] xl: neuter vcpu-set --ignore-host Konrad Rzeszutek Wilk
2013-09-26  7:23   ` Dario Faggioli
2013-09-26 12:45     ` Konrad Rzeszutek Wilk
2013-09-26  9:06   ` Ian Campbell
2013-09-26 12:48     ` Konrad Rzeszutek Wilk
2013-09-26 16:25       ` George Dunlap
2013-09-27  1:44         ` Konrad Rzeszutek Wilk
2013-09-26 15:28     ` Konrad Rzeszutek Wilk
2013-09-26 15:47       ` Ian Campbell
2013-09-26 16:01         ` Andrew Cooper [this message]
2013-09-26 16:05           ` Ian Campbell
2013-09-27  1:52         ` Konrad Rzeszutek Wilk
2013-09-27  8:41           ` Ian Campbell
2013-09-30 18:40             ` Konrad Rzeszutek Wilk
2013-09-25 20:40 ` [PATCH 2/2] xl/vcpuset: Make it work for PV guests Konrad Rzeszutek Wilk
2013-09-26  9:10   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52445A56.6060505@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).