From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v3 08/11] xen: arm: rewrite start of day
 page table and cpu bring up
Date: Fri, 27 Sep 2013 16:30:17 +0100
Message-ID: <5245A489.2020502@linaro.org>
References: <1380276965.29483.178.camel@kazak.uk.xensource.com>
	<1380277240-27900-8-git-send-email-ian.campbell@citrix.com>
	<52458885.9080705@linaro.org>
	<1380291044.8994.100.camel@hastur.hellion.org.uk>
	<1380291667.29483.196.camel@kazak.uk.xensource.com>
	<524596A7.7090101@linaro.org>
	<1380292706.13347.10.camel@kazak.uk.xensource.com>
	<1380295073.13347.12.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1380295073.13347.12.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 09/27/2013 04:17 PM, Ian Campbell wrote:
> On Fri, 2013-09-27 at 15:38 +0100, Ian Campbell wrote:
>> @@ -535,6 +572,10 @@ int init_secondary_pagetables(int cpu)
>>      per_cpu(xen_pgtable, cpu) = first;
>>      per_cpu(xen_dommap, cpu) = domheap;
>>  
>> +    /* Set init_ttbr for this CPU coming up */
>> +    init_ttbr = (uintptr_t) THIS_CPU_PGTABLE + phys_offset;
>> +    flush_xen_dcache(init_ttbr);
>> +
>>      return 0;
>>  }
>>  #endif 
> 
> /me puts on his donkey ears.
> 
> We don't really want to run all 32-bit CPUs on CPU0's pagetables, do we
> now...

It's now boot on the arndale. With the 2 changes (this one and the
smp_cpus_init...):

Acked-by: Julien Grall <julien.grall@linaro.org>

> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index 18fa979..99857ea 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -572,7 +572,7 @@ int init_secondary_pagetables(int cpu)
>      per_cpu(xen_dommap, cpu) = domheap;
>  
>      /* Set init_ttbr for this CPU coming up */
> -    init_ttbr = (uintptr_t) THIS_CPU_PGTABLE + phys_offset;
> +    init_ttbr = __pa(first);
>      flush_xen_dcache(init_ttbr);
>  
>      return 0;
> 
> Now, where did I put my brown paper bag.
> 
> Ian.
> 
> 


-- 
Julien Grall