From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v1 07/12] libxl: remove the Qemu bodge for driver domain devices Date: Wed, 2 Oct 2013 10:45:51 +0100 Message-ID: <524BEB4F.5000208@citrix.com> References: <1380705874-58491-1-git-send-email-roger.pau@citrix.com> <1380705874-58491-8-git-send-email-roger.pau@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VRJ0F-0001pP-RL for xen-devel@lists.xenproject.org; Wed, 02 Oct 2013 09:45:56 +0000 In-Reply-To: <1380705874-58491-8-git-send-email-roger.pau@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Roger Pau Monne Cc: xen-devel@lists.xenproject.org, Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org T24gMDIvMTAvMTMgMTA6MjQsIFJvZ2VyIFBhdSBNb25uZSB3cm90ZToKPiBXaGVuIFFlbXUgaXMg bGF1bmNoZWQgZnJvbSBhIGRyaXZlciBkb21haW4gdG8gYWN0IGFzIGEgUFYgZGlzawo+IGJhY2tl bmQgd2UgY2FuIG1ha2Ugc3VyZSB0aGF0IFFlbXUgaXMgcnVubmluZyBiZWZvcmUgZGV0YWNoaW5n Cj4gZGV2aWNlcywgc28gdGhlcmUncyBubyBuZWVkIGZvciB0aGUgYm9kZ2UgdGhlcmUuCj4KPiBT aWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4KPiBD YzogSWFuIEphY2tzb24gPElhbi5KYWNrc29uQGV1LmNpdHJpeC5jb20+Cj4gQ2M6IElhbiBDYW1w YmVsbCA8aWFuLmNhbXBiZWxsQGNpdHJpeC5jb20+Cj4gLS0tCj4gIHRvb2xzL2xpYnhsL2xpYnhs X2RldmljZS5jIHwgICA3MSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0t LS0tCj4gIDEgZmlsZXMgY2hhbmdlZCwgNTMgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRpb25zKC0p Cj4KPiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGlieGwvbGlieGxfZGV2aWNlLmMgYi90b29scy9saWJ4 bC9saWJ4bF9kZXZpY2UuYwo+IGluZGV4IGZiYWIwZDUuLjA0MDRmOGQgMTAwNjQ0Cj4gLS0tIGEv dG9vbHMvbGlieGwvbGlieGxfZGV2aWNlLmMKPiArKysgYi90b29scy9saWJ4bC9saWJ4bF9kZXZp Y2UuYwo+IEBAIC03ODAsMzAgKzc4MCwzOCBAQCB2b2lkIGxpYnhsX19pbml0aWF0ZV9kZXZpY2Vf cmVtb3ZlKGxpYnhsX19lZ2MgKmVnYywKPiAgICAgIGNoYXIgKm9ubGluZV9wYXRoID0gR0NTUFJJ TlRGKCIlcy9vbmxpbmUiLCBiZV9wYXRoKTsKPiAgICAgIGNvbnN0IGNoYXIgKnN0YXRlOwo+ICAg ICAgbGlieGxfZG9taW5mbyBpbmZvOwo+IC0gICAgdWludDMyX3QgZG9taWQgPSBhb2Rldi0+ZGV2 LT5kb21pZDsKPiArICAgIHVpbnQzMl90IG15X2RvbWlkLCBkb21pZCA9IGFvZGV2LT5kZXYtPmRv bWlkOwo+ICAgICAgaW50IHJjID0gMDsKPiAgCj4gLSAgICBsaWJ4bF9kb21pbmZvX2luaXQoJmlu Zm8pOwo+IC0gICAgcmMgPSBsaWJ4bF9kb21haW5faW5mbyhDVFgsICZpbmZvLCBkb21pZCk7Cj4g KyAgICByYyA9IGxpYnhsX19nZXRfZG9taWQoZ2MsICZteV9kb21pZCk7Cj4gICAgICBpZiAocmMp IHsKPiAtICAgICAgICBMT0coRVJST1IsICJ1bmFibGUgdG8gZ2V0IGluZm8gZm9yIGRvbWFpbiAl ZCIsIGRvbWlkKTsKPiArICAgICAgICBMT0coRVJST1IsICJ1bmFibGUgdG8gZ2V0IG15IGRvbWlk Iik7Cj4gICAgICAgICAgZ290byBvdXQ7Cj4gICAgICB9Cj4gLSAgICBpZiAoUUVNVV9CQUNLRU5E KGFvZGV2LT5kZXYpICYmCj4gLSAgICAgICAgKGluZm8ucGF1c2VkIHx8IGluZm8uZHlpbmcgfHwg aW5mby5zaHV0ZG93bikpIHsKPiAtICAgICAgICAvKgo+IC0gICAgICAgICAqIFRPRE86IDQuMiBC b2RnZSBkdWUgdG8gUUVNVSwgc2VlIGNvbW1lbnQgb24gdG9wIG9mCj4gLSAgICAgICAgICogbGli eGxfX2luaXRpYXRlX2RldmljZV9yZW1vdmUgaW4gbGlieGxfaW50ZXJuYWwuaAo+IC0gICAgICAg ICAqLwo+IC0gICAgICAgIHJjID0gbGlieGxfX2V2X3RpbWVfcmVnaXN0ZXJfcmVsKGdjLCAmYW9k ZXYtPnRpbWVvdXQsCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ZGV2aWNlX3FlbXVfdGltZW91dCwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBMSUJYTF9RRU1VX0JPREdFX1RJTUVPVVQgKiAxMDAwKTsKPiArCj4gKyAgICBpZiAo bXlfZG9taWQgPT0gTElCWExfVE9PTFNUQUNLX0RPTUlEKSB7Cj4gKyAgICAgICAgbGlieGxfZG9t aW5mb19pbml0KCZpbmZvKTsKPiArICAgICAgICByYyA9IGxpYnhsX2RvbWFpbl9pbmZvKENUWCwg JmluZm8sIGRvbWlkKTsKPiAgICAgICAgICBpZiAocmMpIHsKPiAtICAgICAgICAgICAgTE9HKEVS Uk9SLCAidW5hYmxlIHRvIHJlZ2lzdGVyIHRpbWVvdXQgZm9yIFFlbXUgZGV2aWNlICVzIiwKPiAt ICAgICAgICAgICAgICAgICAgICAgICBiZV9wYXRoKTsKPiArICAgICAgICAgICAgTE9HKEVSUk9S LCAidW5hYmxlIHRvIGdldCBpbmZvIGZvciBkb21haW4gJWQiLCBkb21pZCk7Cj4gICAgICAgICAg ICAgIGdvdG8gb3V0Owo+ICAgICAgICAgIH0KPiAtICAgICAgICByZXR1cm47Cj4gKyAgICAgICAg aWYgKFFFTVVfQkFDS0VORChhb2Rldi0+ZGV2KSAmJgo+ICsgICAgICAgICAgICAoaW5mby5wYXVz ZWQgfHwgaW5mby5keWluZyB8fCBpbmZvLnNodXRkb3duKSkgewo+ICsgICAgICAgICAgICAvKgo+ ICsgICAgICAgICAgICAgKiBUT0RPOiA0LjIgQm9kZ2UgZHVlIHRvIFFFTVUsIHNlZSBjb21tZW50 IG9uIHRvcCBvZgo+ICsgICAgICAgICAgICAgKiBsaWJ4bF9faW5pdGlhdGVfZGV2aWNlX3JlbW92 ZSBpbiBsaWJ4bF9pbnRlcm5hbC5oCj4gKyAgICAgICAgICAgICAqLwo+ICsgICAgICAgICAgICBy YyA9IGxpYnhsX19ldl90aW1lX3JlZ2lzdGVyX3JlbChnYywgJmFvZGV2LT50aW1lb3V0LAo+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkZXZpY2VfcWVtdV90 aW1lb3V0LAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBM SUJYTF9RRU1VX0JPREdFX1RJTUVPVVQgKiAxMDAwKTsKPiArICAgICAgICAgICAgaWYgKHJjKSB7 Cj4gKyAgICAgICAgICAgICAgICBMT0coRVJST1IsICJ1bmFibGUgdG8gcmVnaXN0ZXIgdGltZW91 dCBmb3IgUWVtdSBkZXZpY2UgJXMiLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICBiZV9w YXRoKTsKPiArICAgICAgICAgICAgICAgIGdvdG8gb3V0Owo+ICsgICAgICAgICAgICB9Cj4gKyAg ICAgICAgICAgIHJldHVybjsKPiArICAgICAgICB9Cj4gICAgICB9Cj4gIAo+ICAgICAgZm9yICg7 Oykgewo+IEBAIC04NzIsMTkgKzg4MCw0NiBAQCBzdGF0aWMgdm9pZCBkZXZpY2VfcWVtdV90aW1l b3V0KGxpYnhsX19lZ2MgKmVnYywgbGlieGxfX2V2X3RpbWUgKmV2LAo+ICAgICAgU1RBVEVfQU9f R0MoYW9kZXYtPmFvKTsKPiAgICAgIGNoYXIgKmJlX3BhdGggPSBsaWJ4bF9fZGV2aWNlX2JhY2tl bmRfcGF0aChnYywgYW9kZXYtPmRldik7Cj4gICAgICBjaGFyICpzdGF0ZV9wYXRoID0gR0NTUFJJ TlRGKCIlcy9zdGF0ZSIsIGJlX3BhdGgpOwo+ICsgICAgY29uc3QgY2hhciAqeHNfc3RhdGU7Cj4g KyAgICB4c190cmFuc2FjdGlvbl90IHQgPSAwOwo+ICAgICAgaW50IHJjID0gMDsKPiAgCj4gICAg ICBsaWJ4bF9fZXZfdGltZV9kZXJlZ2lzdGVyKGdjLCAmYW9kZXYtPnRpbWVvdXQpOwo+ICAKPiAt ICAgIHJjID0gbGlieGxfX3hzX3dyaXRlX2NoZWNrZWQoZ2MsIFhCVF9OVUxMLCBzdGF0ZV9wYXRo LCAiNiIpOwo+IC0gICAgaWYgKHJjKSBnb3RvIG91dDsKPiArICAgIGZvciAoOzspIHsKPiArICAg ICAgICByYyA9IGxpYnhsX194c190cmFuc2FjdGlvbl9zdGFydChnYywgJnQpOwo+ICsgICAgICAg IGlmIChyYykgewo+ICsgICAgICAgICAgICBMT0coRVJST1IsICJ1bmFibGUgdG8gc3RhcnQgdHJh bnNhY3Rpb24iKTsKPiArICAgICAgICAgICAgZ290byBvdXQ7Cj4gKyAgICAgICAgfQo+ICsKPiAr ICAgICAgICAvKgo+ICsgICAgICAgICAqIENoZWNrIHRoYXQgdGhlIHN0YXRlIHBhdGggZXhpc3Rz IGFuZCBpcyBhY3R1YWxseSBkaWZmZXJlbnQgdGhhbgo+ICsgICAgICAgICAqIDYgYmVmb3JlIHVu Y29uZGl0aW9uYWxseSBzZXR0aW5nIGl0LiBJZiBRZW11IHJ1bnMgb24gYSBkcml2ZXIKPiArICAg ICAgICAgKiBkb21haW4gaXQgaXMgcG9zc2libGUgdGhhdCB0aGUgZHJpdmVyIGRvbWFpbiBoYXMg YWxyZWFkeSBjbGVhbmVkCj4gKyAgICAgICAgICogdGhlIGJhY2tlbmQgcGF0aCBpZiB0aGUgZGV2 aWNlIGhhcyByZWFjaGVkIHN0YXRlIDYuCj4gKyAgICAgICAgICovCj4gKyAgICAgICAgcmMgPSBs aWJ4bF9feHNfcmVhZF9jaGVja2VkKGdjLCBYQlRfTlVMTCwgc3RhdGVfcGF0aCwgJnhzX3N0YXRl KTsKPiArICAgICAgICBpZiAocmMpIGdvdG8gb3V0Owo+ICsKPiArICAgICAgICBpZiAoeHNfc3Rh dGUgJiYgYXRvaSh4c19zdGF0ZSkgIT0gWGVuYnVzU3RhdGVDbG9zZWQpIHsKPiArICAgICAgICAg ICAgcmMgPSBsaWJ4bF9feHNfd3JpdGVfY2hlY2tlZChnYywgWEJUX05VTEwsIHN0YXRlX3BhdGgs ICI2Iik7Cj4gKyAgICAgICAgICAgIGlmIChyYykgZ290byBvdXQ7Cj4gKyAgICAgICAgfQo+ICsK PiArICAgICAgICByYyA9IGxpYnhsX194c190cmFuc2FjdGlvbl9jb21taXQoZ2MsICZ0KTsKPiAr ICAgICAgICBpZiAoIXJjKSBicmVhazsKPiArICAgICAgICBpZiAocmMgPCAwKSBnb3RvIG91dDsK PiArICAgIH0KPiAgCj4gICAgICBkZXZpY2VfaG90cGx1ZyhlZ2MsIGFvZGV2KTsKPiAgICAgIHJl dHVybjsKPiAgCj4gIG91dDoKPiArICAgIGxpYnhsX194c190cmFuc2FjdGlvbl9hYm9ydChnYywg JnQpOwo+ICAgICAgYW9kZXYtPnJjID0gcmM7Cj4gICAgICBkZXZpY2VfaG90cGx1Z19kb25lKGVn YywgYW9kZXYpOwo+ICsgICAgcmV0dXJuOwoKVGhpcyBpcyBhIHZvaWQgZnVuY3Rpb24uICBUaGUg cmV0dXJuIGhlcmUgaXMgY29tcGxldGVseSBzdXBlcmZsdW91cy4KCn5BbmRyZXcKCj4gIH0KPiAg Cj4gIHN0YXRpYyB2b2lkIGRldmljZV9iYWNrZW5kX2NhbGxiYWNrKGxpYnhsX19lZ2MgKmVnYywg bGlieGxfX2V2X2RldnN0YXRlICpkcywKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54 ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=