From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH 01/16] xen/events: refactor retrigger_dynirq() and resend_irq_on_evtchn() Date: Wed, 02 Oct 2013 23:06:40 +0100 Message-ID: <524C98F0.7080102@cantab.net> References: <1380734101-2991-1-git-send-email-david.vrabel@citrix.com> <1380734101-2991-2-git-send-email-david.vrabel@citrix.com> <20131002204335.GA25399@phenom.dumpdata.com> <524C8999.5020508@cantab.net> <20131002210815.GA25661@phenom.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20131002210815.GA25661@phenom.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Boris Ostrovsky , David Vrabel , Jan Beulich , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 02/10/2013 22:08, Konrad Rzeszutek Wilk wrote: > On Wed, Oct 02, 2013 at 10:01:13PM +0100, David Vrabel wrote: >> On 02/10/2013 21:43, Konrad Rzeszutek Wilk wrote: >>> On Wed, Oct 02, 2013 at 06:14:46PM +0100, David Vrabel wrote: >>>> From: David Vrabel >>>> >>>> These two function did the same thing with different parameters, put >>>> the common bits in retrigger_evtchn(). >>>> >>>> This changes the return value of resend_irq_on_evtchn() but the only >>>> caller (in arch/ia64/xen/irq_xen.c) ignored the return value so this >>>> is fine. >>>> >>>> Signed-off-by: David Vrabel >>> >>> Hm, I thought I acked it? >> >> You said "Looks good to me" which wasn't official enough to add as a tag. > > It is in the Linux kernel, see Documentation/SubmittingPatches: I don't think it's sensible to interpret potentially ambiguous language into a standard tag, regardless of what other Linux maintainers may do. This has gone wrong in the past. If you want a tag added you should write it out in full (which you still haven't done). David