From mboxrd@z Thu Jan  1 00:00:00 1970
From: Fabio Fantoni <fabio.fantoni@m2r.biz>
Subject: Re: [Xen-devel] [RFC PATCH] vga: Start supporting
 resolution not multiple of 16 correctly.
Date: Thu, 03 Oct 2013 14:09:33 +0200
Message-ID: <524D5E7D.4080108@m2r.biz>
References: <CAHt6W4fxEv9bMQHjSA=O3vuHxaH+sL9raaj9OsD2b-j4=3aYRw@mail.gmail.com>
	<518C8B16.4060108@suse.de>
	<CAHt6W4duQaPmjK-USDx7GpAk0VuFOY4+W1D0rPgZ52_Lx+Ug5w@mail.gmail.com>
	<51EE4CE1.7060402@tiscali.it> <51EE68DE.7080405@redhat.com>
	<CAHt6W4e=Rcs6ZgMS=xjbE03D61Wd4vBQR-265yws4ug9xoLyTg@mail.gmail.com>
	<20130925161236.GN2924@reaktio.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
In-Reply-To: <20130925161236.GN2924@reaktio.net>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
To: =?ISO-8859-1?Q?Pasi_K=E4rkk=E4inen?= <pasik@iki.fi>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, xen-devel@lists.xensource.com, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Fabio Fantoni <fantonifabio@tiscali.it>, qemu-devel <qemu-devel@nongnu.org>, Alon Levy <alevy@redhat.com>, Frediano Ziglio <freddy77@gmail.com>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, Gerd Hoffmann <kraxel@redhat.com>
List-Id: xen-devel@lists.xenproject.org

Il 25/09/2013 18:12, Pasi Kärkkäinen ha scritto:
> On Sun, Jul 28, 2013 at 05:56:01PM +0100, Frediano Ziglio wrote:
>>     2013/7/23 Gerd Hoffmann <[1]kraxel@redhat.com>
>>
>>       Â  Hi,
>>       > Tested-by: Fabio Fantoni <[2]fabio.fantoni@m2r.biz>
>>       >
>>       > I tested it for a long time with spice on xen (because qxl will be
>>       fully
>>       > working only after adding SSE support on hvm domUs). It works, I think
>>       > it is good to add this and the respective vgabios patch on upstream.
>>
>>       >> Â  Â  Â  Â  Â case VBE_DISPI_INDEX_XRES:
>>       >> - Â  Â  Â  Â  Â  Â if ((val <= VBE_DISPI_MAX_XRES) && ((val & 7) ==
>>       0)) {
>>       >> + Â  Â  Â  Â  Â  Â if ((val <= VBE_DISPI_MAX_XRES) && ((val & 1) ==
>>       0)) {
>>       >> Â  Â  Â  Â  Â  Â  Â  Â  Â s->vbe_regs[s->vbe_index] = val;
>>       >> Â  Â  Â  Â  Â  Â  Â }
>>       >> Â  Â  Â  Â  Â  Â  Â break;
>>
>>       It's not that simple. Â With 32bit depths common today it will work
>>       fine,
>>       but for lower depths (especially those lower than 8bit) this will give
>>       you broken scanline alignment.
>>
>>       cheers,
>>       Â  Gerd
>>
>>     In the card I tested the scanline is keep aligned but for this reason is
>>     not directly computed by maxx * bits but is something bigger.
>>
> Hmm.. so is an update needed for this patch? It'd be nice to get this patch in!

Ping

Some statistics for evidence the importance to add support for 1366x768 
and other resolutions:
http://www.rapidtables.com/web/dev/screen-resolution-statistics.htm
http://www.geek.com/chips/most-popular-screen-resolution-increases-to-1366-x-768-1482311/

>
> -- Pasi
>   
>>     Frediano
>>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel