From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH RFC v13 02/20] pvh prep: code motion
Date: Fri, 4 Oct 2013 17:29:43 +0200
Message-ID: <524EDEE7.9030708@citrix.com>
References: <1379955000-11050-1-git-send-email-george.dunlap@eu.citrix.com>
	<1379955000-11050-3-git-send-email-george.dunlap@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1379955000-11050-3-git-send-email-george.dunlap@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <george.dunlap@eu.citrix.com>
Cc: Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 23/09/13 18:49, George Dunlap wrote:
> There are many functions where PVH requires some code in common with
> HVM.  Rearrange some of these functions so that the code is together.
> 
> In general, the HVM code that PVH also uses includes:
>  - cacheattr functionality
>  - paging
>  - hvm_funcs
>  - hvm_assert_evtchn_irq tasklet
>  - tm_list
>  - hvm_params
> 
> And code that PVH shares with PV but not with PVH:
>  - updating the domain wallclock
>  - setting v->is_initialized
> 
> There should be no end-to-end changes in behavior.

According to my bisection, this patch breaks HVM domains, here is the 
failure when trying to boot a HVM domain:

(XEN) <vm_launch_fail> error code 7
(XEN) domain_crash_sync called from vmcs.c:1224
(XEN) Domain 1 (vcpu#0) crashed on cpu#7:
(XEN) ----[ Xen-4.4-unstable  x86_64  debug=y  Not tainted ]----
(XEN) CPU:    7
(XEN) RIP:    0000:[<0000000000000000>]
(XEN) RFLAGS: 0000000000000002   CONTEXT: hvm guest
(XEN) rax: 0000000000000000   rbx: ffff83019a148000   rcx: ffff83019a14ff80
(XEN) rdx: ffff82d0801cd03f   rsi: 0000000000000000   rdi: ffff82d0801da5ec
(XEN) rbp: ffff82d080105a78   rsp: 0000000000000000   r8:  0000000000000004
(XEN) r9:  ffff82d080105ae7   r10: ffff83019a14ff70   r11: 0000000000000000
(XEN) r12: ffff83019a14ff50   r13: ffff83011da64000   r14: 0000000000000004
(XEN) r15: ffff82d080184a90   cr0: 0000000000000011   cr4: 0000000000000000
(XEN) cr3: 0000000000000000   cr2: 0000000000000000
(XEN) ds: 0000   es: 0000   fs: 0000   gs: 0000   ss: 0000   cs: 0000