From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [PATCH] Allow building of XEN from source on a system without internet access. Date: Fri, 4 Oct 2013 14:43:42 -0400 Message-ID: <524F0C5E.80808@terremark.com> References: <1380892649-8627-1-git-send-email-dslutz@verizon.com> <524EDD9402000078000F8DDC@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VSAMV-0006np-Ho for xen-devel@lists.xenproject.org; Fri, 04 Oct 2013 18:44:27 +0000 In-Reply-To: <524EDD9402000078000F8DDC@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel , ian.jackson@eu.citrix.com, ian.campbell@citrix.com, Don Slutz , stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 10/04/13 09:24, Jan Beulich wrote: >>>> On 04.10.13 at 15:17, Don Slutz wrote: >> Do the same with XEN_EXTFILES_URL, QEMU_REMOTE, IPXE_GIT_URL, and >> IPXE_TARBALL_URL as QEMU_UPSTREAM_URL, SEABIOS_UPSTREAM_URL, etc. >> >> Signed-off-by: Don Slutz >> --- >> Config.mk | 6 +++--- >> tools/firmware/etherboot/Makefile | 6 +++--- >> 2 files changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/Config.mk b/Config.mk >> index a26c7c0..8bbab8a 100644 >> --- a/Config.mk >> +++ b/Config.mk >> @@ -212,15 +212,15 @@ EMBEDDED_EXTRA_CFLAGS += -fno-exceptions >> XSM_ENABLE ?= n >> FLASK_ENABLE ?= $(XSM_ENABLE) >> >> -XEN_EXTFILES_URL=http://xenbits.xen.org/xen-extfiles >> +XEN_EXTFILES_URL ?= http://xenbits.xen.org/xen-extfiles > Given the change here and further down - what is it that doesn't > work when you run "make XEN_EXTFILES_URL=..."? I understand > that you may want to pass these settings through the environment, > but if the command line approach works the patch title is wrong. > > Jan Yes, these are passed via the environment. Will fix the patch title. -Don Slutz >> # All the files at that location were downloaded from elsewhere on >> # the internet. The original download URL is preserved as a comment >> # near the place in the Xen Makefiles where the file is used. >> >> ifeq ($(GIT_HTTP),y) >> -QEMU_REMOTE=http://xenbits.xen.org/git-http/qemu-xen-unstable.git >> +QEMU_REMOTE ?= http://xenbits.xen.org/git-http/qemu-xen-unstable.git >> else >> -QEMU_REMOTE=git://xenbits.xen.org/qemu-xen-unstable.git >> +QEMU_REMOTE ?= git://xenbits.xen.org/qemu-xen-unstable.git >> endif >> >> ifeq ($(GIT_HTTP),y) >> diff --git a/tools/firmware/etherboot/Makefile >> b/tools/firmware/etherboot/Makefile >> index 15561fc..a0578d2 100644 >> --- a/tools/firmware/etherboot/Makefile >> +++ b/tools/firmware/etherboot/Makefile >> @@ -5,14 +5,14 @@ include $(XEN_ROOT)/tools/Rules.mk >> include Config >> >> ifeq ($(GIT_HTTP),y) >> -IPXE_GIT_URL := http://git.ipxe.org/ipxe.git >> +IPXE_GIT_URL ?= http://git.ipxe.org/ipxe.git >> else >> -IPXE_GIT_URL := git://git.ipxe.org/ipxe.git >> +IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git >> endif >> >> IPXE_GIT_TAG := 9a93db3f0947484e30e753bbd61a10b17336e20e >> >> -IPXE_TARBALL_URL := $(XEN_EXTFILES_URL)/ipxe-git-$(IPXE_GIT_TAG).tar.gz >> +IPXE_TARBALL_URL ?= $(XEN_EXTFILES_URL)/ipxe-git-$(IPXE_GIT_TAG).tar.gz >> >> D=ipxe >> T=ipxe.tar.gz >> -- >> 1.7.1 >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xen.org >> http://lists.xen.org/xen-devel > >