[PATCH] Allow building of XEN from source on a system without internet access.

[PATCH] Allow building of XEN from source on a system without internet access.

[Don Slutz]

Do the same with XEN_EXTFILES_URL, QEMU_REMOTE, IPXE_GIT_URL, and IPXE_TARBALL_URL as QEMU_UPSTREAM_URL, SEABIOS_UPSTREAM_URL, etc.

Signed-off-by: Don Slutz <dslutz@verizon.com>
---
 Config.mk                         |    6 +++---
 tools/firmware/etherboot/Makefile |    6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/Config.mk b/Config.mk
index a26c7c0..8bbab8a 100644
--- a/Config.mk
+++ b/Config.mk
@@ -212,15 +212,15 @@ EMBEDDED_EXTRA_CFLAGS += -fno-exceptions
 XSM_ENABLE ?= n
 FLASK_ENABLE ?= $(XSM_ENABLE)
 
-XEN_EXTFILES_URL=http://xenbits.xen.org/xen-extfiles
+XEN_EXTFILES_URL ?= http://xenbits.xen.org/xen-extfiles
 # All the files at that location were downloaded from elsewhere on
 # the internet.  The original download URL is preserved as a comment
 # near the place in the Xen Makefiles where the file is used.
 
 ifeq ($(GIT_HTTP),y)
-QEMU_REMOTE=http://xenbits.xen.org/git-http/qemu-xen-unstable.git
+QEMU_REMOTE ?= http://xenbits.xen.org/git-http/qemu-xen-unstable.git
 else
-QEMU_REMOTE=git://xenbits.xen.org/qemu-xen-unstable.git
+QEMU_REMOTE ?= git://xenbits.xen.org/qemu-xen-unstable.git
 endif
 
 ifeq ($(GIT_HTTP),y)
diff --git a/tools/firmware/etherboot/Makefile b/tools/firmware/etherboot/Makefile
index 15561fc..a0578d2 100644
--- a/tools/firmware/etherboot/Makefile
+++ b/tools/firmware/etherboot/Makefile
@@ -5,14 +5,14 @@ include $(XEN_ROOT)/tools/Rules.mk
 include Config
 
 ifeq ($(GIT_HTTP),y)
-IPXE_GIT_URL := http://git.ipxe.org/ipxe.git
+IPXE_GIT_URL ?= http://git.ipxe.org/ipxe.git
 else
-IPXE_GIT_URL := git://git.ipxe.org/ipxe.git
+IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git
 endif
 
 IPXE_GIT_TAG := 9a93db3f0947484e30e753bbd61a10b17336e20e
 
-IPXE_TARBALL_URL := $(XEN_EXTFILES_URL)/ipxe-git-$(IPXE_GIT_TAG).tar.gz
+IPXE_TARBALL_URL ?= $(XEN_EXTFILES_URL)/ipxe-git-$(IPXE_GIT_TAG).tar.gz
 
 D=ipxe
 T=ipxe.tar.gz
-- 
1.7.1

Re: [PATCH] Allow building of XEN from source on a system without internet access.

[Jan Beulich]

>>> On 04.10.13 at 15:17, Don Slutz <dslutz@verizon.com> wrote:
> Do the same with XEN_EXTFILES_URL, QEMU_REMOTE, IPXE_GIT_URL, and 
> IPXE_TARBALL_URL as QEMU_UPSTREAM_URL, SEABIOS_UPSTREAM_URL, etc.
> 
> Signed-off-by: Don Slutz <dslutz@verizon.com>
> ---
>  Config.mk                         |    6 +++---
>  tools/firmware/etherboot/Makefile |    6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Config.mk b/Config.mk
> index a26c7c0..8bbab8a 100644
> --- a/Config.mk
> +++ b/Config.mk
> @@ -212,15 +212,15 @@ EMBEDDED_EXTRA_CFLAGS += -fno-exceptions
>  XSM_ENABLE ?= n
>  FLASK_ENABLE ?= $(XSM_ENABLE)
>  
> -XEN_EXTFILES_URL=http://xenbits.xen.org/xen-extfiles 
> +XEN_EXTFILES_URL ?= http://xenbits.xen.org/xen-extfiles 

Given the change here and further down - what is it that doesn't
work when you run "make XEN_EXTFILES_URL=..."? I understand
that you may want to pass these settings through the environment,
but if the command line approach works the patch title is wrong.

Jan

>  # All the files at that location were downloaded from elsewhere on
>  # the internet.  The original download URL is preserved as a comment
>  # near the place in the Xen Makefiles where the file is used.
>  
>  ifeq ($(GIT_HTTP),y)
> -QEMU_REMOTE=http://xenbits.xen.org/git-http/qemu-xen-unstable.git 
> +QEMU_REMOTE ?= http://xenbits.xen.org/git-http/qemu-xen-unstable.git 
>  else
> -QEMU_REMOTE=git://xenbits.xen.org/qemu-xen-unstable.git
> +QEMU_REMOTE ?= git://xenbits.xen.org/qemu-xen-unstable.git
>  endif
>  
>  ifeq ($(GIT_HTTP),y)
> diff --git a/tools/firmware/etherboot/Makefile 
> b/tools/firmware/etherboot/Makefile
> index 15561fc..a0578d2 100644
> --- a/tools/firmware/etherboot/Makefile
> +++ b/tools/firmware/etherboot/Makefile
> @@ -5,14 +5,14 @@ include $(XEN_ROOT)/tools/Rules.mk
>  include Config
>  
>  ifeq ($(GIT_HTTP),y)
> -IPXE_GIT_URL := http://git.ipxe.org/ipxe.git 
> +IPXE_GIT_URL ?= http://git.ipxe.org/ipxe.git 
>  else
> -IPXE_GIT_URL := git://git.ipxe.org/ipxe.git
> +IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git
>  endif
>  
>  IPXE_GIT_TAG := 9a93db3f0947484e30e753bbd61a10b17336e20e
>  
> -IPXE_TARBALL_URL := $(XEN_EXTFILES_URL)/ipxe-git-$(IPXE_GIT_TAG).tar.gz
> +IPXE_TARBALL_URL ?= $(XEN_EXTFILES_URL)/ipxe-git-$(IPXE_GIT_TAG).tar.gz
>  
>  D=ipxe
>  T=ipxe.tar.gz
> -- 
> 1.7.1
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org 
> http://lists.xen.org/xen-devel 

Re: [PATCH] Allow building of XEN from source on a system without internet access.

[Don Slutz]

On 10/04/13 09:24, Jan Beulich wrote:
>>>> On 04.10.13 at 15:17, Don Slutz <dslutz@verizon.com> wrote:
>> Do the same with XEN_EXTFILES_URL, QEMU_REMOTE, IPXE_GIT_URL, and
>> IPXE_TARBALL_URL as QEMU_UPSTREAM_URL, SEABIOS_UPSTREAM_URL, etc.
>>
>> Signed-off-by: Don Slutz <dslutz@verizon.com>
>> ---
>>   Config.mk                         |    6 +++---
>>   tools/firmware/etherboot/Makefile |    6 +++---
>>   2 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/Config.mk b/Config.mk
>> index a26c7c0..8bbab8a 100644
>> --- a/Config.mk
>> +++ b/Config.mk
>> @@ -212,15 +212,15 @@ EMBEDDED_EXTRA_CFLAGS += -fno-exceptions
>>   XSM_ENABLE ?= n
>>   FLASK_ENABLE ?= $(XSM_ENABLE)
>>   
>> -XEN_EXTFILES_URL=http://xenbits.xen.org/xen-extfiles
>> +XEN_EXTFILES_URL ?= http://xenbits.xen.org/xen-extfiles
> Given the change here and further down - what is it that doesn't
> work when you run "make XEN_EXTFILES_URL=..."? I understand
> that you may want to pass these settings through the environment,
> but if the command line approach works the patch title is wrong.
>
> Jan
Yes, these are passed via the environment.  Will fix the patch title.
    -Don Slutz
>>   # All the files at that location were downloaded from elsewhere on
>>   # the internet.  The original download URL is preserved as a comment
>>   # near the place in the Xen Makefiles where the file is used.
>>   
>>   ifeq ($(GIT_HTTP),y)
>> -QEMU_REMOTE=http://xenbits.xen.org/git-http/qemu-xen-unstable.git
>> +QEMU_REMOTE ?= http://xenbits.xen.org/git-http/qemu-xen-unstable.git
>>   else
>> -QEMU_REMOTE=git://xenbits.xen.org/qemu-xen-unstable.git
>> +QEMU_REMOTE ?= git://xenbits.xen.org/qemu-xen-unstable.git
>>   endif
>>   
>>   ifeq ($(GIT_HTTP),y)
>> diff --git a/tools/firmware/etherboot/Makefile
>> b/tools/firmware/etherboot/Makefile
>> index 15561fc..a0578d2 100644
>> --- a/tools/firmware/etherboot/Makefile
>> +++ b/tools/firmware/etherboot/Makefile
>> @@ -5,14 +5,14 @@ include $(XEN_ROOT)/tools/Rules.mk
>>   include Config
>>   
>>   ifeq ($(GIT_HTTP),y)
>> -IPXE_GIT_URL := http://git.ipxe.org/ipxe.git
>> +IPXE_GIT_URL ?= http://git.ipxe.org/ipxe.git
>>   else
>> -IPXE_GIT_URL := git://git.ipxe.org/ipxe.git
>> +IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git
>>   endif
>>   
>>   IPXE_GIT_TAG := 9a93db3f0947484e30e753bbd61a10b17336e20e
>>   
>> -IPXE_TARBALL_URL := $(XEN_EXTFILES_URL)/ipxe-git-$(IPXE_GIT_TAG).tar.gz
>> +IPXE_TARBALL_URL ?= $(XEN_EXTFILES_URL)/ipxe-git-$(IPXE_GIT_TAG).tar.gz
>>   
>>   D=ipxe
>>   T=ipxe.tar.gz
>> -- 
>> 1.7.1
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> http://lists.xen.org/xen-devel
>
>

Re: [PATCH] Allow building of XEN from source on a system without internet access.

[Ian Jackson]

Don Slutz writes ("Re: [Xen-devel] [PATCH] Allow building of XEN from source on a system without internet access."):
> On 10/04/13 09:24, Jan Beulich wrote:
...
> >> -XEN_EXTFILES_URL=http://xenbits.xen.org/xen-extfiles
> >> +XEN_EXTFILES_URL ?= http://xenbits.xen.org/xen-extfiles
> > Given the change here and further down - what is it that doesn't
> > work when you run "make XEN_EXTFILES_URL=..."? I understand
> > that you may want to pass these settings through the environment,
> > but if the command line approach works the patch title is wrong.
>
> Yes, these are passed via the environment.  Will fix the patch title.

Right, thanks.

FAOD I approve of this kind of change, but did you know that you can
put settings like this in .config in the root of the Xen tree ?

Ian.

Re: [PATCH] Allow building of XEN from source on a system without internet access.

[Don Slutz]

On 10/14/13 11:52, Ian Jackson wrote:
> Don Slutz writes ("Re: [Xen-devel] [PATCH] Allow building of XEN from source on a system without internet access."):
>> On 10/04/13 09:24, Jan Beulich wrote:
> ...
>>>> -XEN_EXTFILES_URL=http://xenbits.xen.org/xen-extfiles
>>>> +XEN_EXTFILES_URL ?= http://xenbits.xen.org/xen-extfiles
>>> Given the change here and further down - what is it that doesn't
>>> work when you run "make XEN_EXTFILES_URL=..."? I understand
>>> that you may want to pass these settings through the environment,
>>> but if the command line approach works the patch title is wrong.
>> Yes, these are passed via the environment.  Will fix the patch title.
> Right, thanks.
>
> FAOD I approve of this kind of change, but did you know that you can
> put settings like this in .config in the root of the Xen tree ?
I did.  So how about a title of "Allow building of XEN from source on a 
system without internet access by specifying external stuff in .config"?
    -Don Slutz
> Ian.

Re: [PATCH] Allow building of XEN from source on a system without internet access.

[Ian Campbell]

On Fri, 2013-10-04 at 14:43 -0400, Don Slutz wrote:

> Yes, these are passed via the environment.  Will fix the patch title.

I don't think I saw this, did I miss it or is it still pending?

Re: [PATCH] Allow building of XEN from source on a system without internet access.

[Don Slutz]

[-- Attachment #1.1: Type: text/plain, Size: 546 bytes --]

On 10/31/13 15:04, Ian Campbell wrote:
> On Fri, 2013-10-04 at 14:43 -0400, Don Slutz wrote:
>
>> Yes, these are passed via the environment.  Will fix the patch title.
> I don't think I saw this, did I miss it or is it still pending?
>
>
Sorry about the slow response.

It was still pending (v2 is out).  I was not happy with the title:

    Allow building of XEN from source on a system without internet
    access by specifying external stuff in .config


I think the newer one is better.  Also I spent time on kexec stuff 1st.
     -Don Slutz

[-- Attachment #1.2: Type: text/html, Size: 1136 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel