From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v2] libxl: remove qemu default devices for upstream qemu Date: Tue, 8 Oct 2013 15:54:16 +0100 Message-ID: <52541C98.5070509@eu.citrix.com> References: <1380541988-6105-1-git-send-email-fabio.fantoni@m2r.biz> <52541C05.9020606@m2r.biz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <52541C05.9020606@m2r.biz> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Fabio Fantoni Cc: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com, Stefano.Stabellini@eu.citrix.com, Ian.Jackson@eu.citrix.com, wei.lui2@citrix.com, Anthony PERARD List-Id: xen-devel@lists.xenproject.org On 10/08/2013 03:51 PM, Fabio Fantoni wrote: > Il 30/09/2013 13:53, Fabio Fantoni ha scritto: >> Remove default devices created by qemu. Qemu will create only devices >> defined by xen, since the devices not defined by xen are not usable. >> Remove deleting of empty floppy no more needed with nodefault. > > Any comment on this? > > Thanks for any reply. It sounds like a good idea to me, but I'm not in a position to review it. You should CC Anthony Perard along with Stefano for patches that have to do with qemu. -George > >> >> Changes from v1: >> Fix multi-line comment style >> >> Signed-off-by: Fabio Fantoni >> --- >> tools/libxl/libxl_dm.c | 10 +++++++--- >> 1 file changed, 7 insertions(+), 3 deletions(-) >> >> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c >> index 2c6f5d9..eb71089 100644 >> --- a/tools/libxl/libxl_dm.c >> +++ b/tools/libxl/libxl_dm.c >> @@ -392,6 +392,13 @@ static char ** >> libxl__build_device_model_args_new(libxl__gc *gc, >> flexarray_append(dm_args, "-mon"); >> flexarray_append(dm_args, "chardev=libxl-cmd,mode=control"); >> + /* >> + * Remove default devices created by qemu. Qemu will create only >> devices >> + * defined by xen, since the devices not defined by xen are not >> usable. >> + * Remove deleting of empty floppy no more needed with nodefault. >> + */ >> + flexarray_append(dm_args, "-nodefaults"); >> + >> if (b_info->type == LIBXL_DOMAIN_TYPE_PV) { >> flexarray_append(dm_args, "-xen-attach"); >> } >> @@ -457,9 +464,6 @@ static char ** >> libxl__build_device_model_args_new(libxl__gc *gc, >> if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) { >> int ioemu_nics = 0; >> - /* Disable useless empty floppy drive */ >> - flexarray_vappend(dm_args, "-global", "isa-fdc.driveA=", NULL); >> - >> if (b_info->u.hvm.serial) { >> flexarray_vappend(dm_args, "-serial", >> b_info->u.hvm.serial, NULL); >> } >