From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH 08/11] evtchn: add FIFO-based event channel
 hypercalls and port ops
Date: Tue, 8 Oct 2013 17:48:25 +0100
Message-ID: <52543759.2000809@citrix.com>
References: <1381236045-27020-1-git-send-email-david.vrabel@citrix.com>	<1381236045-27020-9-git-send-email-david.vrabel@citrix.com>
	<525439FA02000078000F9AB0@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <david.vrabel@citrix.com>) id 1VTaSU-0006Yt-Da
	for xen-devel@lists.xenproject.org; Tue, 08 Oct 2013 16:48:30 +0000
In-Reply-To: <525439FA02000078000F9AB0@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>, David Vrabel <david.vrabel@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 08/10/13 15:59, Jan Beulich wrote:
>>>> On 08.10.13 at 14:40, David Vrabel <david.vrabel@citrix.com> wrote:
>> From: David Vrabel <david.vrabel@citrix.com>
>>
>> Add the implementation for the FIFO-based event channel ABI.  The new
>> hypercall sub-ops (EVTCHNOP_init_control, EVTCHNOP_expand_array) and
>> the required evtchn_ops (set_pending, unmask, etc.).
>>
>> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
> 
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Thanks!

>> +static void set_priority_all(struct domain *d, unsigned int priority)
>> +{
>> +    unsigned int port;
>> +
>> +    for ( port = 1; port < d->max_evtchns; port++ )
>> +    {
>> +        if ( !port_is_valid(d, port) )
>> +            break;
>> +
>> +        evtchn_port_set_priority(d, evtchn_from_port(d, port), priority);
> 
> Couldn't you short cut this and call your internal function directly
> instead of through the generic wrapper?

I dithered over this at the time I added this and I don't recall why.
I'll make a note to change this up in a follow-up patch.

David