From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] xen/x86: Remove GB macro in asm-x86/config.h Date: Tue, 8 Oct 2013 17:49:46 +0100 Message-ID: <525437AA.1070703@citrix.com> References: <1381250913-15913-1-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1381250913-15913-1-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: patches@linaro.org, Keir Fraser , ian.campbell@citrix.com, Jan Beulich , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 08/10/13 17:48, Julien Grall wrote: > Commit 983843e "xen: Add macros MB and GB" introduce a generic GB macro. > By mistake, the macro in asm-x86/config.h was not removed. This is result to > a compilation error when Xen is build for x86. > > Signed-off-by: Julien Grall > CC: Keir Fraser > CC: Jan Beulich Reviewed-by: Andrew Cooper > --- > xen/include/asm-x86/config.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/xen/include/asm-x86/config.h b/xen/include/asm-x86/config.h > index 3980e06..99d0e2c 100644 > --- a/xen/include/asm-x86/config.h > +++ b/xen/include/asm-x86/config.h > @@ -129,7 +129,6 @@ extern unsigned char boot_edid_info[128]; > #define PML4_ADDR(_slot) \ > (((_AC(_slot, UL) >> 8) * _AC(0xffff000000000000,UL)) | \ > (_AC(_slot, UL) << PML4_ENTRY_BITS)) > -#define GB(_gb) (_AC(_gb, UL) << 30) > > /* > * Memory layout: