From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Daniel Kiper <dkiper@net-space.pl>
Cc: Keir Fraser <keir@xen.org>,
David Vrabel <david.vrabel@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCHv9 0/9] Xen: extend kexec hypercall for use with pv-ops kernels
Date: Wed, 9 Oct 2013 16:52:32 +0100 [thread overview]
Message-ID: <52557BC0.3050508@citrix.com> (raw)
In-Reply-To: <20131009152616.GB30387@router-fw-old.local.net-space.pl>
On 09/10/13 16:26, Daniel Kiper wrote:
> On Tue, Oct 08, 2013 at 05:55:01PM +0100, David Vrabel wrote:
>> The series (for Xen 4.4) improves the kexec hypercall by making Xen
>> responsible for loading and relocating the image. This allows kexec
>> to be usable by pv-ops kernels and should allow kexec to be usable
>> from a HVM or PVH privileged domain.
> As I can see you taken some sugestions into account. Thanks. But...
> Why did not you send this patch series to kexec@lists.infradead.org
> and my Oracle address? Why did not you implemented kexec hypercall
> function to get info about loaded images? Andrew and I asked about that.
> What about setting GPRs to known value (e.g. 0 like in Linux Kernel)
> before jumping into purgatory?
I had forgotten that I had already asked that question (in person) to
David, and that he had answered.
There is no real usecase for such a hypercall, and introduces a
TimeOfCheck-TimeOfUse race condition, as nothing stops the interleaving
of a KEXECOP_unload hypercall.
The KEXECOP_kexec hypercall is well specified in so far as it will
return if an image is not loaded.
~Andrew
>
> By the way, you do not need to save and restore %rdi, %rsi and %rbx
> in relocate_pages() in xen/arch/x86/x86_64/kexec_reloc.S.
>
> Daniel
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-10-09 15:52 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 16:55 [PATCHv9 0/9] Xen: extend kexec hypercall for use with pv-ops kernels David Vrabel
2013-10-08 16:55 ` [PATCH 1/9] x86: give FIX_EFI_MPF its own fixmap entry David Vrabel
2013-10-08 16:55 ` [PATCH 2/9] kexec: add public interface for improved load/unload sub-ops David Vrabel
2013-10-08 16:55 ` [PATCH 3/9] kexec: add infrastructure for handling kexec images David Vrabel
2013-11-05 22:39 ` Don Slutz
2013-11-06 8:12 ` Jan Beulich
2013-10-08 16:55 ` [PATCH 4/9] kexec: extend hypercall with improved load/unload ops David Vrabel
2013-11-05 22:43 ` Don Slutz
2013-10-08 16:55 ` [PATCH 5/9] xen: kexec crash image when dom0 crashes David Vrabel
2013-10-08 16:55 ` [PATCH 6/9] libxc: add hypercall buffer arrays David Vrabel
2013-10-08 16:55 ` [PATCH 7/9] libxc: add API for kexec hypercall David Vrabel
2013-10-08 16:55 ` [PATCH 8/9] x86: check kexec relocation code fits in a page David Vrabel
2013-10-08 16:55 ` [PATCH 9/9] MAINTAINERS: Add KEXEC maintainer David Vrabel
2013-10-08 17:03 ` [PATCHv9 0/9] Xen: extend kexec hypercall for use with pv-ops kernels Andrew Cooper
2013-10-09 15:26 ` Daniel Kiper
2013-10-09 15:52 ` Andrew Cooper [this message]
2013-10-09 16:03 ` David Vrabel
2013-10-10 15:45 ` Daniel Kiper
2013-10-10 16:35 ` David Vrabel
2013-10-10 21:24 ` Daniel Kiper
2013-10-11 6:49 ` Jan Beulich
2013-10-11 8:58 ` Daniel Kiper
2013-10-11 9:56 ` David Vrabel
2013-10-11 11:15 ` Daniel Kiper
2013-10-11 14:06 ` David Vrabel
2013-10-14 13:53 ` Daniel Kiper
2013-10-14 14:14 ` David Vrabel
2013-10-14 18:13 ` Daniel Kiper
2013-10-16 21:09 ` Daniel Kiper
2013-11-14 11:20 ` Daniel Kiper
2013-11-14 11:27 ` David Vrabel
2013-10-18 18:40 ` Daniel Kiper
2013-10-18 23:14 ` David Vrabel
2013-10-21 12:19 ` Daniel Kiper
2013-10-21 12:56 ` David Vrabel
2013-10-21 20:20 ` Daniel Kiper
2013-10-25 9:13 ` Daniel Kiper
2013-10-25 23:04 ` David Vrabel
2013-10-30 16:57 ` David Vrabel
2013-10-31 16:59 ` Don Slutz
2013-10-31 18:30 ` David Vrabel
2013-10-31 20:23 ` Don Slutz
2013-10-31 22:21 ` Daniel Kiper
2013-11-05 17:41 ` Daniel Kiper
2013-11-05 18:01 ` David Vrabel
2013-10-18 23:42 ` Andrew Cooper
2013-10-21 3:11 ` Xu, YongweiX
2013-10-21 10:21 ` David Vrabel
2013-10-21 12:26 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52557BC0.3050508@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=dkiper@net-space.pl \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).