From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCHv9 0/9] Xen: extend kexec hypercall for use
 with pv-ops kernels
Date: Wed, 9 Oct 2013 16:52:32 +0100
Message-ID: <52557BC0.3050508@citrix.com>
References: <1381251310-29449-1-git-send-email-david.vrabel@citrix.com>
	<20131009152616.GB30387@router-fw-old.local.net-space.pl>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20131009152616.GB30387@router-fw-old.local.net-space.pl>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Daniel Kiper <dkiper@net-space.pl>
Cc: Keir Fraser <keir@xen.org>, David Vrabel <david.vrabel@citrix.com>, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 09/10/13 16:26, Daniel Kiper wrote:
> On Tue, Oct 08, 2013 at 05:55:01PM +0100, David Vrabel wrote:
>> The series (for Xen 4.4) improves the kexec hypercall by making Xen
>> responsible for loading and relocating the image.  This allows kexec
>> to be usable by pv-ops kernels and should allow kexec to be usable
>> from a HVM or PVH privileged domain.
> As I can see you taken some sugestions into account. Thanks. But...
> Why did not you send this patch series to kexec@lists.infradead.org
> and my Oracle address? Why did not you implemented kexec hypercall
> function to get info about loaded images? Andrew and I asked about that.
> What about setting GPRs to known value (e.g. 0 like in Linux Kernel)
> before jumping into purgatory?

I had forgotten that I had already asked that question (in person) to
David, and that he had answered.

There is no real usecase for such a hypercall, and introduces a
TimeOfCheck-TimeOfUse race condition, as nothing stops the interleaving
of a KEXECOP_unload hypercall.

The KEXECOP_kexec hypercall is well specified in so far as it will
return if an image is not loaded.

~Andrew

>
> By the way, you do not need to save and restore %rdi, %rsi and %rbx
> in relocate_pages() in xen/arch/x86/x86_64/kexec_reloc.S.
>
> Daniel
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel