From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCHv9 0/9] Xen: extend kexec hypercall for use with pv-ops kernels Date: Wed, 9 Oct 2013 17:03:22 +0100 Message-ID: <52557E4A.2000500@citrix.com> References: <1381251310-29449-1-git-send-email-david.vrabel@citrix.com> <20131009152616.GB30387@router-fw-old.local.net-space.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20131009152616.GB30387@router-fw-old.local.net-space.pl> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Daniel Kiper Cc: Keir Fraser , Jan Beulich , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 09/10/13 16:26, Daniel Kiper wrote: > On Tue, Oct 08, 2013 at 05:55:01PM +0100, David Vrabel wrote: >> The series (for Xen 4.4) improves the kexec hypercall by making >> Xen responsible for loading and relocating the image. This allows >> kexec to be usable by pv-ops kernels and should allow kexec to be >> usable from a HVM or PVH privileged domain. > > As I can see you taken some sugestions into account. Thanks. But... > Why did not you send this patch series to kexec@lists.infradead.org > and my Oracle address? I reckoned that the kexec list subscribers were sick of this Xen-only series by now. Omitting your Cc was accidental, sorry. > Why did not you implemented kexec hypercall function to get info about > loaded images? Because it is not needed. > What about setting GPRs to known value (e.g. 0 like in Linux Kernel) > before jumping into purgatory? I have (repeatedly) explained why and you have not provided a sensible reason why they should be zeroed. > By the way, you do not need to save and restore %rdi, %rsi and %rbx > in relocate_pages() in xen/arch/x86/x86_64/kexec_reloc.S. This is done so relocate_pages() behaves like a proper function with the standard calling convention. David