From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v4 8/9] xen/arm: Implement hypercall for
 dirty page tracing
Date: Thu, 10 Oct 2013 15:10:41 +0100
Message-ID: <5256B561.5070000@linaro.org>
References: <1380861845-23268-1-git-send-email-jaeyong.yoo@samsung.com>
	<1380861845-23268-9-git-send-email-jaeyong.yoo@samsung.com>
	<5252B0EC.4010809@citrix.com> <5252D87A.2050305@samsung.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5252D87A.2050305@samsung.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Eugene Fedotov <e.fedotov@samsung.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 10/07/2013 04:51 PM, Eugene Fedotov wrote:

> Let me explain. I think the difference between handle_page_fault and
> handle_mmio is that the ongoing memory operation (that trapped here)
> should be repeated after handle_page_fault (the page fault handler
> clears read-only bit), but should be stepped out after handle_mmio (to
> do this we call advance_pc to increase the pc register). So, advance_pc
> is intentionally missed.

Oh right, thanks for the explanation!

-- 
Julien Grall