From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH 04/16] xen/events: replace raw bit ops with
	functions
Date: Mon, 14 Oct 2013 12:30:59 -0400
Message-ID: <525C1C43.8070808@oracle.com>
References: <1381236555-27493-1-git-send-email-david.vrabel@citrix.com>
	<1381236555-27493-5-git-send-email-david.vrabel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1381236555-27493-5-git-send-email-david.vrabel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 10/08/2013 08:49 AM, David Vrabel wrote:
> From: Wei Liu <wei.liu2@citrix.com>
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
>   drivers/xen/events.c |    3 +--
>   1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> index 359e983..fec5da4 100644
> --- a/drivers/xen/events.c
> +++ b/drivers/xen/events.c
> @@ -1548,13 +1548,12 @@ static int set_affinity_irq(struct irq_data *data, const struct cpumask *dest,
>   static int retrigger_evtchn(int evtchn)
>   {
>   	int masked;
> -	struct shared_info *s = HYPERVISOR_shared_info;
>   
>   	if (!VALID_EVTCHN(evtchn))
>   		return 0;
>   
>   	masked = test_and_set_mask(evtchn);
> -	sync_set_bit(evtchn, BM(s->evtchn_pending));
> +	set_evtchn(evtchn);
>   	if (!masked)
>   		unmask_evtchn(evtchn);

There are other places in this file that manipulate evtchn_pending bits 
(e.g. in unmask_evtchn()). As long as this change is made, those places 
should probably be updated as well.

You also need a commit message for this and previous patch.

-boris