From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH 06/16] xen/events: move 2-level specific code into its own file Date: Mon, 14 Oct 2013 17:53:23 +0100 Message-ID: <525C2183.8060208@citrix.com> References: <1381236555-27493-1-git-send-email-david.vrabel@citrix.com> <1381236555-27493-7-git-send-email-david.vrabel@citrix.com> <525C20ED.6010903@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <525C20ED.6010903@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky Cc: Jan Beulich , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 14/10/13 17:50, Boris Ostrovsky wrote: > > This chunk dealing with timer interrupt has been completely removed. I > see that you have a later patch that raises priority of VIRQ_TIMER. If > that patch is replacement for what this chunk used to do, should you be > removing this code in that patch? > > Also, it appears that you are not simply moving code around. There are > some changes to logic (for example this one) and it should be reflected > in the commit message. Oops. It was just code motion in v1 but the new file as not been kept up-to-date. I'll redo this whole patch from scratch. David