From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH 12/16] xen/evtchn: support more than 4096
	ports
Date: Mon, 14 Oct 2013 14:06:05 -0400
Message-ID: <525C328D.20506@oracle.com>
References: <1381236555-27493-1-git-send-email-david.vrabel@citrix.com>
	<1381236555-27493-13-git-send-email-david.vrabel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1381236555-27493-13-git-send-email-david.vrabel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 10/08/2013 08:49 AM, David Vrabel wrote:
> From: David Vrabel <david.vrabel@citrix.com>
>
> Remove the check during unbind for NR_EVENT_CHANNELS as this limits
> support to less than 4096 ports.


This is an interface change, you will be returning a different type of 
error (ENOTCONN instead of EINVAL).

Why not check for xen_evtchn_nr_channels()?

-boris


>
> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
> ---
>   drivers/xen/evtchn.c |    4 ----
>   1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c
> index 8b3a69a..1b0fc44 100644
> --- a/drivers/xen/evtchn.c
> +++ b/drivers/xen/evtchn.c
> @@ -416,10 +416,6 @@ static long evtchn_ioctl(struct file *file,
>   		if (copy_from_user(&unbind, uarg, sizeof(unbind)))
>   			break;
>   
> -		rc = -EINVAL;
> -		if (unbind.port >= NR_EVENT_CHANNELS)
> -			break;
> -
>   		rc = -ENOTCONN;
>   		evtchn = find_evtchn(u, unbind.port);
>   		if (!evtchn)