From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH RFC 14/15] libxl: build a device tree for ARM guests Date: Tue, 15 Oct 2013 14:46:13 +0100 Message-ID: <525D4725.8020004@linaro.org> References: <1381163944.21562.129.camel@kazak.uk.xensource.com> <1381164001-1446-14-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1381164001-1446-14-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 10/07/2013 05:40 PM, Ian Campbell wrote: > Uses xc_dom_devicetree_mem which was just added. The call to this needs to be > carefully sequenced to be after xc_dom_parse_image (so we can tell which kind > of guest we are building, although we don't use this yet) and before > xc_dom_mem_init which tries to decide where to place the FDT in guest RAM. > > Removes libxl_noarch which would only have been used by IA64 after this > change. Remove IA64 as part of this patch. > > There is no attempt to expose this as a configuration setting for the user. > > Includes a debug hook to dump the dtb to a file for inspection. > > TODO: > - Hardcoded armv8 bits need abstracting. Perhaps e.g. read CPU compatiblity > node from sysfs? > - Try it with armv7 > - Debug hook should be #ifdef DEBUG? > - Various values (e.g. GIC base addresses, evtchn PPI) should be passed > down to the hypervisor by some mechanism I've not decided on yet. Perhaps > domctl but maybe better would be via the HVM save format to more easily > support migration of the settings? > - TODOs and //comments in the code > > Signed-off-by: Ian Campbell > --- [..] > +int libxl__arch_domain_configure(libxl__gc *gc, > + libxl_domain_build_info *info, > + struct xc_dom_image *dom) > +{ [..] > + res = make_memory_node(gc, fdt, 0x80000000UL, 0x8000000UL); dom->rambase_pfn << PAGE_SHIFT. and the size should not be hardcoded. -- Julien Grall