From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 4/5] xen: arm: make sure pagetable mask macros have appropriate size Date: Mon, 21 Oct 2013 16:53:14 +0100 Message-ID: <52654DEA.7020402@linaro.org> References: <1381145870.21562.93.camel@kazak.uk.xensource.com> <1381145896-25890-4-git-send-email-ian.campbell@citrix.com> <52654860.8050408@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <52654860.8050408@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: tim@xen.org, anup.patel@linaro.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 10/21/2013 04:29 PM, Julien Grall wrote: > > > On 10/07/2013 12:38 PM, Ian Campbell wrote: >> {ZEROETH,FIRST,SECOND,THIRD}_MASK are used with physical addresses >> which may >> be larger than 32 bits. Therefore ensure that they are wide enough by >> casting >> to paddr_t otherwise we may truncate addresses on 32-bit. >> >> Signed-off-by: Ian Campbell > Acked-by: Julien Grall I have just noticed that I have acked the wrong version of the patch series. Sorry... -- Julien Grall