From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/irq: Print direct vector mappings in
 the 'i' debug key
Date: Mon, 28 Oct 2013 10:11:00 +0000
Message-ID: <526E3834.9060604@citrix.com>
References: <1382613840-15289-1-git-send-email-andrew.cooper3@citrix.com>
	<526E3DF802000078000FD29C@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1Vajn7-0001Fr-1q
	for xen-devel@lists.xenproject.org; Mon, 28 Oct 2013 10:11:21 +0000
In-Reply-To: <526E3DF802000078000FD29C@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 28/10/13 09:35, Jan Beulich wrote:
>>>> On 24.10.13 at 13:24, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>> @@ -2285,6 +2285,14 @@ static void dump_irqs(unsigned char key)
>>          xfree(ssid);
>>      }
>>  
>> +    printk("Direct vector information:\n");
>> +    for ( i = 0; i < NR_VECTORS; ++i )
>> +        if ( direct_apic_vector[i] )
>> +        {
>> +            printk("   %#04x -> ", i);
>> +            print_function("%s()\n", (unsigned long)direct_apic_vector[i]);
> Did you build test this? I can't seem to find any print_function() in
> the staging tree...
>
> Jan
>

Sorry.  I developed this on my branch which includes the patch to drop
the +0/<len> (posted a while back).  I clearly forgotten to refresh the
patch when testing against staging.  (I really need to get out of the
habit of doing this).

I will get around to doing the %p modifiers in some amount of free time,
but print_symbol() was intended here.  v2 on its way.

~Andrew